fix(deps): update dependency @google-cloud/secret-manager to v3 (exte…

…rnal-secrets#345) * fix(deps): update dependency @google-cloud/secret-manager to v3 * fix: use public api of secret-manager dependency Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Markus Maga <[email protected]>
umlublin · Sep 28, 2020 · 2bf42db · 2bf42db
1 parent 4c2ae7b
commit 2bf42db
Show file tree

Hide file tree

Showing 3 changed files with 276 additions and 158 deletions.
diff --git a/lib/backends/gcp-secrets-manager-backend.js b/lib/backends/gcp-secrets-manager-backend.js
@@ -18,7 +18,7 @@ class GCPSecretsManagerBackend extends KVBackend {
  * Gets the project id from auth object from the GCP Secret Manager Client
  */
  _getProjectId () {
- return this._client.auth._cachedProjectId
+ return this._client.auth.getProjectId()
  }
 
  /**
@@ -31,7 +31,7 @@ class GCPSecretsManagerBackend extends KVBackend {
  async _get ({ key, keyOptions, specOptions: { projectId } }) {
  if (!projectId) {
  // get the project id from client
- projectId = this._getProjectId()
+ projectId = await this._getProjectId()
  }
 
  let secretVersion = 'latest'
@@ -41,10 +41,10 @@ class GCPSecretsManagerBackend extends KVBackend {
 
  this._logger.info(`fetching secret ${key} from GCP Secret for project ${projectId} with version ${secretVersion}`)
 
- const version = await this._client.accessSecretVersion({
+ const [version] = await this._client.accessSecretVersion({
  name: 'projects/' + projectId + '/secrets/' + key + '/versions/' + secretVersion
  })
- const secret = version[0].payload.data.toString('utf8')
+ const secret = version.payload.data.toString('utf8')
  // Handle binary files - this is useful when you've stored a base64 encoded string
  if (keyOptions && keyOptions.isBinary) {
  return Buffer.from(secret, 'base64')