Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify eth block delay #367

Merged
merged 6 commits into from
Sep 26, 2022
Merged

chore: modify eth block delay #367

merged 6 commits into from
Sep 26, 2022

Conversation

facundomedica
Copy link

Matching what GB is doing in their own orchestrator.

Closes #361

@facundomedica
Copy link
Author

facundomedica commented Sep 26, 2022

This might make E2E tests slow, but well, for safety sake we'll need to have it Nah it won't, the E2E tests use a different chain id

@codecov-commenter
Copy link

Codecov Report

Merging #367 (b246730) into main (13fb428) will decrease coverage by 0.05%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
- Coverage   57.87%   57.81%   -0.06%     
==========================================
  Files          17       17              
  Lines        2039     2041       +2     
==========================================
  Hits         1180     1180              
- Misses        756      758       +2     
  Partials      103      103              
Impacted Files Coverage Δ
orchestrator/main_loops.go 7.46% <75.00%> (-0.05%) ⬇️

@facundomedica facundomedica merged commit 86ac6c4 into main Sep 26, 2022
@facundomedica facundomedica deleted the facu/new-ethdelay branch September 26, 2022 21:03
mergify bot pushed a commit that referenced this pull request Sep 26, 2022
* chore: modify eth block delay

* chore: modify eth block delay

* fix test

* fix test

* changelog

* changelog

(cherry picked from commit 86ac6c4)
facundomedica added a commit that referenced this pull request Sep 26, 2022
* chore: modify eth block delay

* chore: modify eth block delay

* fix test

* fix test

* changelog

* changelog

(cherry picked from commit 86ac6c4)

Co-authored-by: Facundo Medica <[email protected]>
facundomedica added a commit that referenced this pull request Oct 1, 2022
* chore: modify eth block delay (#367) (#368)

* chore: modify eth block delay

* chore: modify eth block delay

* fix test

* fix test

* changelog

* changelog

(cherry picked from commit 86ac6c4)

Co-authored-by: Facundo Medica <[email protected]>

* feat: reduce oracle noise msgs (#365) (#369)

* update test scripts

* reduce noise messages of pf

* add more providers to default

* add workflow for v1.0.x

* fix branch name

(cherry picked from commit 13fb428)

Co-authored-by: Rafael Tenfen <[email protected]>
Co-authored-by: Facundo Medica <[email protected]>

* chore: prepare v1.1.0 release (#371)

* chore: prepare v1.1.0 release

* chore: prepare v1.1.0 release

* feat: Add eth merge pause flag

* fix

* fix add flag to cmd

* lint

* fix mergify

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Rafael Tenfen <[email protected]>
mergify bot pushed a commit that referenced this pull request Oct 1, 2022
* chore: modify eth block delay (#367) (#368)

* chore: modify eth block delay

* chore: modify eth block delay

* fix test

* fix test

* changelog

* changelog

(cherry picked from commit 86ac6c4)

Co-authored-by: Facundo Medica <[email protected]>

* feat: reduce oracle noise msgs (#365) (#369)

* update test scripts

* reduce noise messages of pf

* add more providers to default

* add workflow for v1.0.x

* fix branch name

(cherry picked from commit 13fb428)

Co-authored-by: Rafael Tenfen <[email protected]>
Co-authored-by: Facundo Medica <[email protected]>

* chore: prepare v1.1.0 release (#371)

* chore: prepare v1.1.0 release

* chore: prepare v1.1.0 release

* feat: Add eth merge pause flag

* fix

* fix add flag to cmd

* lint

* fix mergify

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Rafael Tenfen <[email protected]>
(cherry picked from commit 8b19cf8)

# Conflicts:
#	CHANGELOG.md
facundomedica added a commit that referenced this pull request Oct 1, 2022
* feat: Add eth merge pause flag (to main) (#376)

* chore: modify eth block delay (#367) (#368)

* chore: modify eth block delay

* chore: modify eth block delay

* fix test

* fix test

* changelog

* changelog

(cherry picked from commit 86ac6c4)

Co-authored-by: Facundo Medica <[email protected]>

* feat: reduce oracle noise msgs (#365) (#369)

* update test scripts

* reduce noise messages of pf

* add more providers to default

* add workflow for v1.0.x

* fix branch name

(cherry picked from commit 13fb428)

Co-authored-by: Rafael Tenfen <[email protected]>
Co-authored-by: Facundo Medica <[email protected]>

* chore: prepare v1.1.0 release (#371)

* chore: prepare v1.1.0 release

* chore: prepare v1.1.0 release

* feat: Add eth merge pause flag

* fix

* fix add flag to cmd

* lint

* fix mergify

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Rafael Tenfen <[email protected]>
(cherry picked from commit 8b19cf8)

# Conflicts:
#	CHANGELOG.md

* fix cl

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: Facundo Medica <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ETH block delay should be the last safe block in ETH PoS
3 participants