feat: add getCurrentBlock func to return latest block confirmed #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafilxTenfen
commented
Jul 25, 2022
RafilxTenfen
commented
- Just separate the function to get the current block, making it possible to start the chain before the confirmation period (like devnet: ganache)
- Helps to reduce the code to review at feat: valset update at least at each 2000 eth blocks #311
Codecov Report
@@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 58.56% 58.44% -0.13%
==========================================
Files 17 17
Lines 2003 2014 +11
==========================================
+ Hits 1173 1177 +4
- Misses 730 735 +5
- Partials 100 102 +2
|
facundomedica
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.