Hackathon h1016 l3 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagan-jaya
suggested changes
Feb 14, 2023
| @@ -152,6 +152,9 @@ base_url = "https://try.access.worldpay.com/" | |||
| base_url = "https://apis.sandbox.globalpay.com/ucp/" | |||
|
|
|||
| # This data is used to call respective connectors for wallets and cards | |||
| [connectors.forte] | |||
| base_url = "https://sandbox.forte.net/api/v3/organizations/org_436911/locations/loc_314200/transactions" | |||
There was a problem hiding this comment.
do not hardcode org id and location. save it in connector_meta while Payment Connector Create
| @@ -519,6 +519,7 @@ pub enum Connector { | |||
| Cybersource, | |||
| #[default] | |||
| Dummy, | |||
| Forte, | |||
There was a problem hiding this comment.
run cargo clippy --all-features --all-targets && cargo +nightly fmt --all and fix the formatting issues
| @@ -153,6 +153,7 @@ pub struct Connectors { | |||
|
|
|||
| // Keep this field separate from the remaining fields | |||
| pub supported: SupportedConnectors, | |||
| pub forte: ConnectorParams, | |||
There was a problem hiding this comment.
run cargo clippy --all-features --all-targets && cargo +nightly fmt --all and fix the formatting issues and fix clippy warning if any
| pub use self::{ | ||
| aci::Aci, adyen::Adyen, applepay::Applepay, authorizedotnet::Authorizedotnet, | ||
| braintree::Braintree, checkout::Checkout, cybersource::Cybersource, fiserv::Fiserv, | ||
| globalpay::Globalpay, klarna::Klarna, payu::Payu, rapyd::Rapyd, shift4::Shift4, stripe::Stripe, | ||
| worldline::Worldline, worldpay::Worldpay, | ||
| forte::Forte, |
There was a problem hiding this comment.
run cargo clippy --all-features --all-targets && cargo +nightly fmt --all and fix clippy warnings if any
Comment on lines
+35
to
+51
| // todo!() | ||
| // let mut headers = vec![( | ||
| // headers::CONTENT_TYPE.to_string(), | ||
| // self.get_content_type().to_string(), | ||
| // )]; | ||
| // let access_token = _req | ||
| // .access_token | ||
| // .clone() | ||
| // .ok_or(errors::ConnectorError::FailedToObtainAuthType)?; | ||
|
|
||
| // let auth_header = ( | ||
| // headers::AUTHORIZATION.to_string(), | ||
| // format!("Basic {}", access_token.token), | ||
| // ); | ||
|
|
||
| // headers.push(auth_header); | ||
| // Ok(headers)\ |
There was a problem hiding this comment.
Suggested change
| // todo!() | |
| // let mut headers = vec![( | |
| // headers::CONTENT_TYPE.to_string(), | |
| // self.get_content_type().to_string(), | |
| // )]; | |
| // let access_token = _req | |
| // .access_token | |
| // .clone() | |
| // .ok_or(errors::ConnectorError::FailedToObtainAuthType)?; | |
| // let auth_header = ( | |
| // headers::AUTHORIZATION.to_string(), | |
| // format!("Basic {}", access_token.token), | |
| // ); | |
| // headers.push(auth_header); | |
| // Ok(headers)\ |
remove commented section
Comment on lines
+119
to
+120
| // status: FortePaymentStatus, | ||
| // id: String, |
| cvv_result: String | ||
| } | ||
|
|
||
| //TODO: Fill the struct with respective fields |
| @@ -166,6 +166,7 @@ where | |||
| let response = call_connector_api(state, request).await; | |||
| match response { | |||
| Ok(body) => { | |||
| logger::debug!(response_response=?body); | |||
| ); | ||
| } | ||
|
|
||
| /*Commented the below test case because the forte pg doesn't work for the expiry year, they are sending it as approved itself, |
There was a problem hiding this comment.
remove all the commented testcases below
| @@ -84,6 +84,9 @@ base_url = "https://apple-pay-gateway.apple.com/" | |||
| [connectors.klarna] | |||
| base_url = "https://api-na.playground.klarna.com/" | |||
|
|
|||
| [connectors.forte] | |||
| base_url = "https://sandbox.forte.net/api/v3/organizations/org_436911/locations/loc_314200/transactions" | |||
There was a problem hiding this comment.
remove the harcoded values and move it to connector meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy