fix loading of pretrained reciprocal relations model

[AdrianKs]

fix for #190

can not override the method _intersect_ids_with_pretrained_embedder in reciprocal_relations_model.py since the base model is created before the reciprocal relations model

[rgemulla]

Why is this needed? Model-specific code in a generic method is problematic from a maintainance point of view. Isn't there a clean solution (e.g., a "load embeddings" method in KgeEmbedder)?

[AdrianKs]

with a "load embeddings" function in KgeEmbedder we still could not achieve a model specific initialization.

The main problem is that we would need to override the intersect_ids method inside the reciprocal relations model. But when we initialize the reciprocal relations model we first create a base model which already initializes the embedders with the method of the base model.
I am not sure how to solve this in a nice way. The design of the reciprocal relations model makes this hard.

[AdrianKs]

one could make the method _intersect_ids_with_pretrained_embedder static and exchange the method in the init method of the reciprocal relations model
But this would also not be nice.

[rgemulla]

The "right" way would be to fix the dataset or not? I.e., improve the alt_dataset in ReciprocalRelationsModel to correctly report the inverse relations with relation_ids by adding these relations with some suffix (e.g., _reciprocal).

[AdrianKs]

You are right. I adapted the relation ids in the alt_dataset.

[rgemulla]

Looks good (and simple)!