Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate penalty for entities only once, if subject embedder == object embedder #140

Merged
merged 5 commits into from
Aug 31, 2020

Conversation

AdrianKs
Copy link
Collaborator

Calculating the penalty only once gives some small time improvements.

@AdrianKs AdrianKs requested a review from rgemulla August 28, 2020 14:35
kge/model/kge_model.py Outdated Show resolved Hide resolved
kge/model/kge_model.py Outdated Show resolved Hide resolved
@rgemulla
Copy link
Member

Read from my point of view.

@rgemulla
Copy link
Member

Add a changelog before merging.

@AdrianKs AdrianKs merged commit 6e6c98d into uma-pi1:master Aug 31, 2020
@AdrianKs AdrianKs deleted the penalize branch August 31, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants