don't rely on reduce being fold-left (fix #3) #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failure seems unrelated ( |
|
@stevengj @ulysses4ever The PR seems to not pass our (arguably minimal) tests. Although I think you're right Steven that it should be a foldLeft, so it's likely a bug in the implementation of MList. |
|
oops, sorry: it seems, I was too fast to merge |
|
@ulysses4ever It's ok! I think the issue is it needs to be a foldL. After switching it to a foldL, the implementation breaks at MList. I'm staring at it now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3.