Remove ipython from check_requirements exclude list
#9841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May resolve e3ff780#commitcomment-87136818 Signed-off-by: Glenn Jocher <[email protected]>
glenn-jocher
referenced
this pull request
Oct 18, 2022
* Allow PyTorch Hub results to display in notebooks * fix CI * fix CI * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix CI * fix CI * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix CI * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix CI * fix CI * fix CI * fix CI * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix CI * fix CI * fix CI Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May resolve e3ff780#commitcomment-87136818
Signed-off-by: Glenn Jocher [email protected]
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improvement in dependency checks for YOLOv5 models.
📊 Key Changes
check_requirementsfunction call.🎯 Purpose & Impact
Purpose: This change ensures that 'ipython' is now a checked dependency, meaning it is considered necessary for the correct operation of YOLOv5 when setting up the environment.
Impact: Users installing YOLOv5 will need to have 'ipython' installed to avoid setup errors. This can also improve user experience by preemptively solving potential issues related to missing 'ipython' dependency.