Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random_perspective param bug in segment #9512

Merged
merged 5 commits into from
Sep 20, 2022

Conversation

FeiGeChuanShu
Copy link
Contributor

@FeiGeChuanShu FeiGeChuanShu commented Sep 20, 2022

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Optimization of data augmentation in image and segmentation label processing.

πŸ“Š Key Changes

  • Simplified the call to the random_perspective function by reformatting the arguments to be more succinct.

🎯 Purpose & Impact

  • The modification streamlines the augmentation code for better readability and potential ease of maintenance.
  • This change has no direct impact on functionality, but it improves the developer experience when working with data loader code. Users should not experience any immediate changes in the performance or output of models.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘‹ Hello @FeiGeChuanShu, thank you for submitting a YOLOv5 πŸš€ PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • βœ… Verify your PR is up-to-date with ultralytics/yolov5 master branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • βœ… Verify all YOLOv5 Continuous Integration (CI) checks are passing.
  • βœ… Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

@glenn-jocher
Copy link
Member

@FeiGeChuanShu I'm not sure if this should be commented. Can you present some before and after results on COCO128 from this PR?

@glenn-jocher
Copy link
Member

@FeiGeChuanShu ah yes you are correct, the argument doesn't exist in the function.

@glenn-jocher glenn-jocher changed the title fix random_perspective param bug in segment Fix random_perspective param bug in segment Sep 20, 2022
@glenn-jocher glenn-jocher changed the title Fix random_perspective param bug in segment Fix random_perspective param bug in segment Sep 20, 2022
@glenn-jocher glenn-jocher merged commit f8b7463 into ultralytics:master Sep 20, 2022
@glenn-jocher
Copy link
Member

@FeiGeChuanShu PR is merged. Thank you for your contributions to YOLOv5 πŸš€ and Vision AI ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants