Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude ipython from hubconf.py check_requirements() #9362

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Sep 10, 2022

Signed-off-by: Glenn Jocher [email protected]

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improvement of dependency checks in model loading routine.

πŸ“Š Key Changes

  • Altered the list of excluded requirements during model initialization, adding 'ipython' to the exclusions.

🎯 Purpose & Impact

  • Purpose: This change ensures that non-critical packages such as 'ipython' do not interfere with the model loading process, if they are not installed.
  • Impact: Streamlines the user experience by preventing unnecessary warnings/errors about 'ipython' during model loading, especially for users who may not use 'ipython' in their workflow. This contributes to a smoother setup and fewer issues for new users getting started with the models.

@glenn-jocher glenn-jocher merged commit cafdd18 into master Sep 10, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch September 10, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant