Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment protobuf in requirements.txt #9207

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Comment protobuf in requirements.txt #9207

merged 1 commit into from
Aug 29, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Aug 29, 2022

The low package version is causing conflicts among other dependencies, commenting it causes no ill effects in CI so this should be fine.

Signed-off-by: Glenn Jocher [email protected]

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improving compatibility by adjusting protobuf requirement.

πŸ“Š Key Changes

  • The specific version restriction for protobuf has been removed from the requirements.txt file.

🎯 Purpose & Impact

  • 🎈 The purpose is to avoid potential conflicts with other packages that require different protobuf versions, enhancing the flexibility of the YOLOv5 installation.
  • πŸ”— This change could impact users by making it easier to integrate YOLOv5 with other software stacks that might need a newer version of protobuf.
  • πŸ‘ Users no longer need to downgrade protobuf manually for compatibility with YOLOv5, which streamlines the setup process.

The low package version is causing conflicts among other dependencies, commenting it causes no ill effects in CI so this should be fine.

Signed-off-by: Glenn Jocher <[email protected]>
@glenn-jocher glenn-jocher merged commit bd5fd78 into master Aug 29, 2022
@glenn-jocher glenn-jocher deleted the remove/protobuf branch August 29, 2022 15:13
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
The low package version is causing conflicts among other dependencies, commenting it causes no ill effects in CI so this should be fine.

Signed-off-by: Glenn Jocher <[email protected]>

Signed-off-by: Glenn Jocher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant