Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename onnx_dynamic -> dynamic #9168

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Rename onnx_dynamic -> dynamic #9168

merged 1 commit into from
Aug 26, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Aug 26, 2022

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improvement in grid reconstruction logic for YOLOv5 model export.

πŸ“Š Key Changes

  • Renamed the onnx_dynamic attribute to dynamic in the Detect class.
  • Updated usage of the renamed attribute in the export.py script.

🎯 Purpose & Impact

  • ✨ Clarification: The renaming makes the code clearer as dynamic is more general and not limited to just ONNX export scenarios.
  • πŸš€ Enhanced Functionality: This change potentially leads to better handling of grid reconstruction when exporting the model for different platforms, not just limited to ONNX.
  • πŸ“ˆ User Experience: Users benefiting from more intuitive attribute naming, along with potentially more reliable export functionality across different model formats.

@glenn-jocher glenn-jocher self-assigned this Aug 26, 2022
@glenn-jocher glenn-jocher merged commit 85d7ae2 into master Aug 26, 2022
@glenn-jocher glenn-jocher deleted the onnx_dynamic_rename branch August 26, 2022 12:34
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant