Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threaded TensorBoard graph logging #9070

Merged
merged 2 commits into from
Aug 21, 2022
Merged

Threaded TensorBoard graph logging #9070

merged 2 commits into from
Aug 21, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Aug 21, 2022

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Refined callback invocations and plot control in training routines.

πŸ“Š Key Changes

  • Removed plots parameter from callback invocations in train.py.
  • Added a self.plots instance variable in the Callbacks class to manage plotting.
  • Simplified plotting-related code in Callbacks methods by using self.plots.
  • Adjusted the thread decorator usage in the Logger's tensorboard graph logging function.

🎯 Purpose & Impact

  • Enhances code maintainability by reducing the complexity of the callback functions' signatures.
  • Provides a cleaner, more centralized way to control plotting, making it easier to enable or disable without affecting function parameters directly.
  • Improvements in logging failures with more descriptive error messages in tensorboard graph logging offer users better debugging information.
  • These changes aim to streamline training code in YOLOv5 and improve the user experience for those monitoring training progress. πŸ‘©β€πŸ’»πŸ“ˆ

@glenn-jocher glenn-jocher self-assigned this Aug 21, 2022
@glenn-jocher glenn-jocher changed the title Log TensorBoard graph on pretrain_routine_end Threaded TensorBoard graph logging Aug 21, 2022
@glenn-jocher glenn-jocher merged commit 8665d55 into master Aug 21, 2022
@glenn-jocher glenn-jocher deleted the update/graph branch August 21, 2022 14:51
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Log TensorBoard graph on pretrain_routine_end

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant