Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update train.py import val as validate #9037

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Aug 19, 2022

Resolves zero-mAP issue.

Signed-off-by: Glenn Jocher [email protected]

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Refactoring validation call in training routine and renaming for clarity.

πŸ“Š Key Changes

  • The val module is now imported as validate to enhance code readability.
  • All instances where val.run() is called have been updated to validate.run().

🎯 Purpose & Impact

  • These changes primarily improve code comprehension by providing a more descriptive name for the validation step.
  • Readability of code could lead to fewer errors and better maintainability.
  • The impact on end users should be minimal as this is an internal codebase quality improvement, with no direct effect on functionality or performance.

@glenn-jocher glenn-jocher self-assigned this Aug 19, 2022
@glenn-jocher glenn-jocher merged commit fdcb92a into master Aug 19, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch August 19, 2022 14:54
@glenn-jocher glenn-jocher linked an issue Aug 19, 2022 that may be closed by this pull request
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Update train.py `import val as validate`

Signed-off-by: Glenn Jocher <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: Glenn Jocher <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precision and recall values returns 0 for every epochs
1 participant