Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOC names dictionary fix #9034

Merged
merged 3 commits into from
Aug 19, 2022
Merged

VOC names dictionary fix #9034

merged 3 commits into from
Aug 19, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Aug 19, 2022

Signed-off-by: Glenn Jocher [email protected]

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved error handling and messaging in data loading and parsing for YOLOv5.

πŸ“Š Key Changes

  • VOC.yaml Updates: Streamlined the names list creation and modified conditional checks within the dataset parser.
  • File Not Found Error: Enhanced the error message clarity when no images or labels are detected by the dataset loader.
  • Empty Labels Check: Added an additional assertion to prompt an error if all labels are empty during the training data preparation.
  • Help URL: Updated the Help URL message format for consistency and readability in error messages throughout the dataloaders module.

🎯 Purpose & Impact

  • Error Clarity: Users will receive clearer error messages, guiding them more effectively when dataset issues arise.
  • Training Data Checks: The added checks ensure users are warned about potential issues with training data, such as missing labels or images, preventing confusion during model training.
  • Documentation Accessibility: Updated Help URL formatting makes it easier for users to seek guidance and follow best practices when training custom models with YOLOv5.

Signed-off-by: Glenn Jocher <[email protected]>
@glenn-jocher glenn-jocher changed the title VOC names dictionary fix VOC names dictionary fix Aug 19, 2022
Signed-off-by: Glenn Jocher <[email protected]>
@glenn-jocher glenn-jocher self-assigned this Aug 19, 2022
@glenn-jocher glenn-jocher merged commit 4a8ab3b into master Aug 19, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch August 19, 2022 13:07
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* VOC names dictionary fix

Signed-off-by: Glenn Jocher <[email protected]>

* Update dataloaders.py

Signed-off-by: Glenn Jocher <[email protected]>

Signed-off-by: Glenn Jocher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant