Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: prevent logging config clobbering" #10177

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 16, 2022

Reverts #10133

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Refactoring of logger setup for cleaner code in the YOLOv5 repository.

πŸ“Š Key Changes

  • Removed the redundancy of declaring a logger_name variable.
  • Directly passed the logger name "yolov5" to the getLogger function.
  • Retained the initialization of logging before defining the global LOGGER object.

🎯 Purpose & Impact

  • 🧹 Code Streamlining: Simplifies the logging setup by eliminating an unnecessary variable assignment without altering functionality.
  • πŸš€ Maintainability: Enhances code maintainability by having one less variable that developers need to track.
  • βœ… No Impact to Users: The update does not affect the features or output that end-users interact with; the functioning of the logger remains consistent.

@glenn-jocher
Copy link
Member Author

@rkechols I need to revert this PR as Colab logging output is now duplicated, i.e.:
https://colab.research.google.com/github/ultralytics/yolov5/blob/master/tutorial.ipynb

Please see if you can create a fix that works correctly with Colab as well, thank you!

Screenshot 2022-11-16 at 19 04 25

@glenn-jocher glenn-jocher merged commit e40662f into master Nov 16, 2022
@glenn-jocher glenn-jocher deleted the revert-10133-patch-1 branch November 16, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant