Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NWIS and WOF tests #219

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Conversation

emiliom
Copy link
Contributor

@emiliom emiliom commented Jun 2, 2023

Fixed errors occurring with NWIS usgs_nwis_test.py::test_get_sites_with_extra_kwarg and WOF wof_test.py::test_core_get_values_waterml_1_1 tests. Both errors involved changes on the data service end, which required small changes to the tests.

Note: now ALL tests that have not been explicitly excluded (skipped) are passing.

After PR #218, where I updated the GitHub CI action, the CI tests spawned by this PR should all succeed 🤞

@emiliom
Copy link
Contributor Author

emiliom commented Jun 2, 2023

The 3.10 test failed, but all others succeeded. The 3.10 test failure is unrelated to the specifics of each test, and is instead a failure to find the conda environment that was created. I suspect that's a hiccup, not a persistent failure. But I'll monitor what happens on the next PR.

I'll submit another PR to remove Python 3.7 from the test matrix. Hopefully the lower number of Python versions testesd will make the 3.10 failure less likely.

@emiliom emiliom merged commit fcdb717 into ulmo-dev:master Jun 2, 2023
3 of 4 checks passed
@emiliom emiliom deleted the tests-fix-nwis-wof branch June 2, 2023 19:31
@emiliom emiliom added this to the 0.8.8 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant