-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add netstandard2.0 target (and convert to new csproj format). #26
Conversation
@ullmark this is causing issues not allowing me to publish my application. Can you approve @MatthewKing pull request as it should fix .netcore 3 class library issues |
Sure thing, I've been busy with life and just saw his pull... Give me a minute
… On 8 Oct 2019, at 23:20, Dhruv Bhavsar ***@***.***> wrote:
@ullmark this is causing issues not allowing me to publish my application. Can you approve @MatthewKing pull request as it should fix .netcore 3 class library issues
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Hi, @MatthewKing @dhruvb14 , working on getting this in when I have time over from my daytime work and kids. I use macOs, and Rider, mostly for .NET now (or want to as much as possible) so trying to get it all working there. Please excuse the hold up. I am also happy to take in contributors to the library if someone are up for it. |
@ullmark I have tested this and we are using it in production from @MatthewKing 's branch. I published the nuget to our internal nuget repo and all my .NetCore 3 Publishing bugs and CI/CD pipelines light up green again. Thanks again @MatthewKing |
@dhruvb14 I've been trying to get it to compile in macOs but getting the following issues:
Maybe it's time to drop those old references... I'll try to fix my windows + install VS2k19 tomorrow. Otherwise I could give someone else publishing rights to the nuget package as well... |
@ullmark Remove the references to net40 and net45 in the csproj and try again. I do not have a Mac or I would try. |
@ullmark If you'd like, I can build the nuget package on my Windows machine (with the net40 and net45 targets intact) and then sent it to you for you to publish. That way, you can retain the publishing rights to the package while still preserving the existing references. |
Sorry guys for the holdup. But getting time for this stuff while having an infant/small child isn't the easiest! 🙈 |
@MatthewKing @dhruvb14 this has been published to nuget as version 1.3.0.. will appear shortly |
@ullmark Thanks! |
Thanks @ullmark |
Hello!
According to this document, Microsoft's current recommendation is to always include a
netstandard2.0
target, even if anetstandard1.x
target is still present/required.Targeting
netstandard2.0
will simplify the dependency graph.This pull request adds a
netstandard2.0
target, while still retaining the existingnet40
,net45
, andnetstandard1.0
targets. In addition, it upgrades from the (now deprecated) xproj format to the new csproj format.Thanks!