docs: avoid mentioning blocking the event loop in async implementation #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I was conflating a few different things when writing about avoiding blocking the event loop as a reason for using threads in the async implementation. The reasoning for using threads is more: - async_stream_zip takes async iterables - which means if delegating to stream_zip, it would need to call async functions like anext or __anext__ from sync functions, and wait for them to complete. - there is only really one choice for this that works/avoids deadlock: run_coroutine_threadsafe. - which means this call must be in a different thread
07be1b3
to
8e8e6f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I was conflating a few different things when writing about avoiding blocking the event loop as a reason for using threads in the async implementation.
The reasoning for using threads is more:
anextor__anext__from sync functions, and wait for them to complete.