feat: impl JsonTypdef for Url (behind a feature flag)

[tomkarw]

No description provided.

[uint]

This is something I need to think about. It's not exactly desirable for a library to add feature flags, and if we start implementing the trait for foreign types, I'm not sure where to draw the line.

[tomkarw]

I get your point. However, it would definitely help with adoption.

Could you release a version with just the ordered field output? That's the one crucial for my use case.

[uint]

Could you release a version with just the ordered field output? That's the one crucial for my use case.

Yes. I'm currently traveling, but I'll try to get it done tomorrow.

[uint]

Okay, let's do it. I had a think and figured expecting jtd-derive users to use workarounds for popular types is hard to justify. I'll only agree to implementations for popular crates, which this is.

[uint]

Suggested change

	[features]
	url = ["dep:url"]

I'm fairly sure this is unnecessary. The feature should be implicitly created bc of optional = true.

[tomkarw]

TIL

[tomkarw]

I think we should do it for all/most of structs in url i.e. Host, Origin, etc? I work on it today.

[uint]

I think we should do it for all/most of structs in url i.e. Host, Origin, etc? I work on it today.

schemars only implements the trait for Url - see here. I'm okay with adding others that are likely to be useful for JSON-based APIs and such.

(sorry about the edit - accident)

[uint]

BTW, any clues about why minimal_deps is failing? I'm scratching my head there.

Edit: probably unrelated, works for me locally. Happy to ignore it.

[tomkarw]

Any pointers on how to manually implement JsonTypedef for an enum? I'm struggling to implement it for url::Host to be precise.

[tomkarw]

BTW, any clues about why minimal_deps is failing? I'm scratching my head there.

That's a funny one. cargo +nighlty update -Z minimal-versions also downgraded trybuild to 1.0.49 and apparently there was a bug in that version, which made the tests that rely on trybuild fail. Bumping the minimal version helped. Out of curiosity, I might bisect the 40 releases trybuild had to see what was the issue there.

[uint]

Any pointers on how to manually implement JsonTypedef for an enum? I'm struggling to implement it for url::Host to be precise.

Ah, it looks like Host uses the default externally tagged enum representation. JSON Typedef can't express that. I'm afraid we can't support it.

[tomkarw]

I'm afraid we can't support it.

Alright. I'm happy to merge as-is, with just support for Url. Feel free to merge and release if you agree.

[uint]

Thanks for diagnosing this!

[uint]

It's all released!

[tomkarw]

Thanks for the quick dev cycle, it's not common in OSS 😅