Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: interactable type definition #603

Closed

Conversation

heimwege
Copy link
Contributor

fixes #602

@heimwege
Copy link
Contributor Author

heimwege commented Apr 12, 2024

@vobu do you need anything from my side for the failing workflows? I feel innocent 😇 Should I update the package-lock in this PR although this is not needed for my change?

@vobu
Copy link

vobu commented Apr 12, 2024

@vobu do you need anything from my side for the failing workflows? I feel innocent 😇 Should I update the package-lock in this PR although this is not needed for my change?

nah, all good. Needed to approve the CI run(s). This will not prevent the fix to come in 👍
plus Google's browser driver download URLs are still broken, throwing 404s all over the place.
We'll wait a couple hours more, then I'll merge the PR anyway :)

@heimwege
Copy link
Contributor Author

@vobu can we re-run the checks and merge this one? 🥺

@vobu
Copy link

vobu commented Apr 26, 2024

yessir, needs #606 though, but both will be done over the weekend.
wake up Monday 🌅 to a fresh wdi5 release 😄

@vobu
Copy link

vobu commented Apr 28, 2024

went in with #606

@vobu vobu closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactable matcher has wrong type definition
2 participants