Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle switchToFrame error #550

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Conversation

nair-sumesh
Copy link
Contributor

No description provided.

@nair-sumesh nair-sumesh temporarily deployed to external October 3, 2023 18:06 — with GitHub Actions Inactive
@nair-sumesh
Copy link
Contributor Author

Resolves: Issue WebDriver Error: no such frame

@vobu
Copy link

vobu commented Oct 4, 2023

thanks for this @nair-sumesh!

  • could you please add a brief src code comment at the try-catch so it becomes clear why it is in there? future development efforts will benefit from this :)
  • could you also commit the current package-lock.json so the authentication tests can run successfully?
    thx!

@nair-sumesh nair-sumesh temporarily deployed to external October 4, 2023 21:10 — with GitHub Actions Inactive
@nair-sumesh
Copy link
Contributor Author

Hi @vobu ,
Done. However the checks failed this time for some reason.

@vobu
Copy link

vobu commented Oct 5, 2023

However the checks failed this time for some reason.

there seem to be references to SAP-internal packages in your package{-lock}.json as the error log shows:

npm ERR! request to https://int.repositories.cloud.sap/artifactory/api/npm/build-milestones-npm/@ui5/cli/-/cli-3.6.1.tgz failed, reason: getaddrinfo EAI_AGAIN int.repositories.cloud.sap

I'll check out the PR and doublecheck.

@vobu vobu temporarily deployed to external October 5, 2023 07:16 — with GitHub Actions Inactive
@vobu
Copy link

vobu commented Oct 5, 2023

the error in the auth tests is a false positive, so good to go!

@vobu vobu merged commit 6c183e3 into ui5-community:main Oct 5, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants