Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a WAM regression test with the MULTI_GASES and MOLECULAR_DIFFUSION options on #714

Merged
merged 48 commits into from
Oct 27, 2021

Conversation

XiaqiongZhou-NOAA
Copy link
Contributor

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA commented Jul 27, 2021

Description

This PR is to add a WAM regression test with both MULTI_GASES and MOLECULAR_DIFFUSION on. The WAM Molecular diffusion option is to replace Rayleigh Damping in FV3 dycore for deep atmosphere applications. This PR also includes the updates to use GFSv16 configuration for MULTI_GASES.

A new set of model input data is required to be saved at INPUTDATA_ROOT. It is available now at /2year/NCEPDEV/emc-ensemble/Xiaqiong.Zhou/FV3_input_data_149.tar

Issue(s) addressed

Testing

Regression tests had run on Hera with Intel and GNU. A new baseline should be created as the code change in dycore will change the results.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • CI: 05833df

Dependencies

NOAA-EMC/fv3atm#354
NOAA-GFDL/GFDL_atmos_cubed_sphere#120
NCAR/ccpp-physics#712

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA marked this pull request as ready for review July 27, 2021 19:58
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR look ok, but I don't understand how the code is supposed to work in fv3atm (and ccpp-physics). Can you please clarify? Thanks.

tests/parm/wam.nml.IN Outdated Show resolved Hide resolved
Copy link
Collaborator

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes here look good. fv3 PR may need to be updated

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: BL
Repo location: /glade/scratch/dtcufsrt/autort/tests/auto/pr/697940344/20211026084513/ufs-weather-model
Please make changes and add the following label back:
cheyenne-intel-BL

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: gnu
Job: BL
Repo location: /glade/scratch/dtcufsrt/autort/tests/auto/pr/697940344/20211026083013/ufs-weather-model
Please manually delete: /glade/scratch/dtcufsrt/FV3_RT/rt_9470
Test control_debug_p7 028 failed in run_test failed
Test regional_control_debug 017 failed in run_test failed
Test control_thompson 006 failed failed
Test control_thompson 006 failed in run_test failed
Test fv3_esg_HAFS_v0_hwrf_thompson 011 failed failed
Test fv3_esg_HAFS_v0_hwrf_thompson 011 failed in run_test failed
Test cpld_control_p7 031 failed failed
Test cpld_control_p7 031 failed in run_test failed
Test fv3_gsd 012 failed failed
Test fv3_gsd 012 failed in run_test failed
Test fv3_HAFS_v0_hwrf_thompson 010 failed failed
Test control_flake 004 failed failed
Test fv3_HAFS_v0_hwrf_thompson 010 failed in run_test failed
Test control_ras 008 failed failed
Test control_flake 004 failed in run_test failed
Test cpld_debug_p7 032 failed failed
Test control_ras 008 failed in run_test failed
Test cpld_debug_p7 032 failed in run_test failed
Test control_rrtmgp 005 failed failed
Test control 001 failed failed
Test control_c48 002 failed failed
Test control_thompson_no_aero 007 failed failed
Test control_p7 009 failed failed
Test control 001 failed in run_test failed
Test control_c48 002 failed in run_test failed
Test control_thompson_no_aero 007 failed in run_test failed
Test control_rrtmgp 005 failed in run_test failed
Test control_p7 009 failed in run_test failed
Test control_stochy_debug 027 failed in run_test failed
Test fv3_rrfs_v1alpha_debug 018 failed in run_test failed
Test fv3_gsd_diag_debug 021 failed in run_test failed
Test fv3_gsd_debug 020 failed in run_test failed
Test control_rrtmgp_debug 025 failed in run_test failed
Test control_ras_debug 026 failed in run_test failed
Test control_thompson_extdiag_debug 024 failed in run_test failed
Test fv3_rrfs_v1beta_debug 019 failed in run_test failed
Test control_thompson_debug 022 failed in run_test failed
Test control_diag_debug 016 failed in run_test failed
Test control_thompson_no_aero_debug 023 failed in run_test failed
Test control_debug 015 failed in run_test failed
Please make changes and add the following label back:
cheyenne-gnu-BL

@climbfuji
Copy link
Collaborator

climbfuji commented Oct 26, 2021 via email

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: orion
Compiler: intel
Job: BL
Repo location: /work/noaa/nems/emc.nemspara/autort/pr/697940344/20211026093015/ufs-weather-model
Please manually delete: /work/noaa/stmp/bcurtis/stmp/bcurtis/FV3_RT/rt_25680
Baseline creation and move successful
Repo location: /work/noaa/nems/emc.nemspara/autort/pr/697940344/20211027035719/ufs-weather-model
Please manually delete: /work/noaa/stmp/bcurtis/stmp/bcurtis/FV3_RT/rt_422758
Test cpld_bmark_p7 010 failed failed
Test cpld_bmark_p7 010 failed in run_test failed
Please make changes and add the following label back:
orion-intel-BL

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is ready to merge, but I have a few questions going forward:

  1. What is the plan for enabling debug tests?
  2. What is the plan for running both prod and debug tests with GNU?

range_warn = .false.
reset_eta = .false.
n_sponge = -1
nudge_qv = .true.
tau = 0.015
tau = -5.0e1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does a negative tau do to the dycore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tau<0 uses the GFS type RF damping, instead of the GFDL type.

@@ -170,8 +171,11 @@
iopt_tbot = 2
iopt_stc = 1
debug = .false.
levr = 90
Copy link
Collaborator

@climbfuji climbfuji Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see that the code runs fine with levr < levs.

@climbfuji climbfuji added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Oct 27, 2021
@junwang-noaa junwang-noaa merged commit 1c5d16f into ufs-community:develop Oct 27, 2021
@XiaqiongZhou-NOAA
Copy link
Contributor Author

This PR is ready to merge, but I have a few questions going forward:

  1. What is the plan for enabling debug tests?
  2. What is the plan for running both prod and debug tests with GNU?

Good questions. I guess these tasks should be done by someone who is hired for the WAM development in the future.

@yangfanglin
Copy link
Collaborator

yangfanglin commented Oct 27, 2021 via email

@SMoorthi-emc
Copy link
Contributor

SMoorthi-emc commented Oct 27, 2021 via email

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Oct 27, 2021 via email

@yangfanglin
Copy link
Collaborator

yangfanglin commented Oct 27, 2021 via email

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Oct 27, 2021 via email

@junwang-noaa
Copy link
Collaborator

Orion RT finished successfully while jobs in nems project has a long waiting queue. The RT log is in the RT baseline: /work/noaa/nems/emc.nemspara/RT/NEMSfv3gfs/develop-20211025/RegressionTests_orion.intel.log

@XiaqiongZhou-NOAA XiaqiongZhou-NOAA deleted the udhmhj6 branch March 29, 2023 17:48
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
Following the migration to a new site for Jenkins, communication between Jenkins and Hera/Jet have been lost. Guidance from this afternoon (April 5, 2023) says that communication should be returned by CoB today. Reactivating Jet in the Jenkinsfile now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants