Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel netcdf writes, inpost with no thread #43

Merged
merged 11 commits into from
Feb 4, 2020

Conversation

junwang-noaa
Copy link
Collaborator

@junwang-noaa junwang-noaa commented Feb 2, 2020

This pull request has following code changes

1)fv3atm pull request 41: parallel netcdf IO. fv3tam issue 23 parallel netcdf writes.
2) update post lib to not compile with "openmp". fv3atm issue 49:inline post does not reproduce with threads.

FV3ATM pull request 41: NOAA-EMC/fv3atm#41

#43:

@junwang-noaa junwang-noaa changed the title parallel netcdf writes and post/ww3 thread safe parallel netcdf writes, post and ww3 thread safe Feb 2, 2020
@jswhit2
Copy link
Collaborator

jswhit2 commented Feb 2, 2020

The files in the cmake directory need to have the PARALLEL_NETCDF option added

@@ -47,7 +47,7 @@ CFLAGS := $(INCLUDE)
FFLAGS := $(INCLUDE) -fno-alias -auto -safe-cray-ptr -ftz -assume byterecl -nowarn -sox -align array64byte

CPPDEFS += -Duse_libMPI -Duse_netCDF -DSPMD -DUSE_LOG_DIAG_FIELD_INFO -DUSE_GFSL63 -DGFS_PHYS -Duse_WRTCOMP
CPPDEFS += -DNEW_TAUCTMAX -DINTERNAL_FILE_NML
CPPDEFS += -DNEW_TAUCTMAX -DINTERNAL_FILE_NML -DNO_PARALLEL_NETCDF
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parallel netCDF not supported on Cray ? It is fine if it is the case. The global workflow needs to have different I/O settings on different platforms.

@junwang-noaa
Copy link
Collaborator Author

junwang-noaa commented Feb 2, 2020 via email

Copy link
Collaborator

@yangfanglin yangfanglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through the changes. I think they are all fine. Knowing the code helps me to think how to generalize the workflow scripts to run the model for various options and on different platforms.

@jedwards4b
Copy link

@junwang-noaa Why do you need to install parallel-netcdf on cray? It is one of their standard modules, if it's not already on the system, you should be able to get support staff to install it.
Cray supported netcdf and parallel-netcdf modules are:
cray-parallel-netcdf
and cray-netcdf

@junwang-noaa
Copy link
Collaborator Author

junwang-noaa commented Feb 3, 2020 via email

@junwang-noaa junwang-noaa changed the title parallel netcdf writes, post and ww3 thread safe parallel netcdf writes, inpost with no thread Feb 4, 2020
@junwang-noaa junwang-noaa merged commit 31821b0 into ufs-community:develop Feb 4, 2020
climbfuji added a commit to climbfuji/ufs-weather-model that referenced this pull request Jun 7, 2020
Adding regression test for FV3_RRFS_v0 from @panll (ufs-community#43) with submodule updates
XiaSun-Atmos pushed a commit to XiaSun-Atmos/ufs-weather-model that referenced this pull request Aug 8, 2020
climbfuji pushed a commit to climbfuji/ufs-weather-model that referenced this pull request Nov 19, 2020
@junwang-noaa junwang-noaa deleted the netcdf_parallel branch April 20, 2021 18:23
bensonr added a commit to bensonr/ufs-weather-model that referenced this pull request Aug 20, 2021
  * new fv3atm (PR ufs-community#374 3fef1582038a90eb117ada9b62cd546740b335a2)
  * updated stochastic_physics (PR ufs-community#43 2dfaec8ca47cea9397c1c1e6e6836ce1acaa421a)

updates fv3_conf/compile_slurm.IN_gaea to use proper queue with ecflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants