update cpl gfsv16 tests, rrtmgp fix and bug fixes in cmeps #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junwang-noaa
requested review from
DeniseWorthen,
DusanJovic-NOAA and
climbfuji
junwang-noaa
added
Baseline Updates
|
Shouldn't there be changes associated with Issue #365? |
|
input.mom6.nml.IN is used by the datm; it looks like you've deleted it? |
|
Oops, I just checked cpl* test, will add it back.
…On Fri, Jan 15, 2021 at 9:15 AM Denise Worthen ***@***.***> wrote:
input.mom6.nml.IN is used by the datm; it looks like you've deleted it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#378 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TPQRUS6H3DEWGUF2BTS2BEYDANCNFSM4WDNYA3Q>
.
|
|
Is it matter if it's lat/lon or Gaussian grid? The seaice_newland.grb is
half degree and it is too old.
…On Fri, Jan 15, 2021 at 9:26 AM Dusan Jovic ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/parm/ccpp.gocart.nml.IN
<#378 (comment)>
:
> @@ -272,7 +272,7 @@
FNVETC = "global_vegtype.igbp.t126.384.190.rg.grb",
FNSOTC = "global_soiltype.statsgo.t126.384.190.rg.grb",
FNSMCC = "global_soilmgldas.t126.384.190.grb",
- FNMSKH = "seaice_newland.grb",
+ FNMSKH = "global_slmask.t1534.3072.1536.grb",
Is this regular lat-lon or gaussian grid? If it's gaussian why?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#378 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TIG43GDSQFGLSW5W3DS2BGAVANCNFSM4WDNYA3Q>
.
|
|
Do we need new input-data-YYYYMMDD directory? Which input data are we deleting or changing? |
The question is about new file, not seaice_newland.grb? Is "global_slmask.t1534.3072.1536.grb" gaussian or regular lat-lon file? |
|
It does not matter what grid it is on as long as it is a grib1 file and is
high resolution.
Moorthi
…On Fri, Jan 15, 2021 at 9:34 AM Dusan Jovic ***@***.***> wrote:
Is it matter if it's lat/lon or Gaussian grid? The seaice_newland.grb is
half degree and it is too old.
The question is about new file, not seaice_newland.grb? Is
"global_slmask.t1534.3072.1536.grb" gaussian or regular lat-lon file?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#378 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYW2B7HKOJKZCKBQWVDS2BG5PANCNFSM4WDNYA3Q>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: [email protected]
Phone: (301) 683-3718 Fax: (301) 683-3718
|
Since it does not matter and FV3 is not spectral model, why don't we use regular lat-lon. I guess interpolating data from regular lat-lon to cubed sphere is faster than from gaussian. |
|
Dusan,
"global_slmask.t1534.3072.1536.grb" is on the Gaussian grid created many
years ago for the "old" GSM. It is so far the mask file of the highest
resolution we have that the model can use. Yes, at some point we should
get rid of all fixed fields on the Gaussian grid, but it takes time and
effort and coordinated effort is required.
Fanglin
…On Fri, Jan 15, 2021 at 10:04 AM Dusan Jovic ***@***.***> wrote:
It does not matter what grid it is on as long as it is a grib1 file and is
high resolution. Moorthi
Since it does not matter and FV3 is not spectral model, why don't we use
regular lat-lon. I guess interpolating data from regular lat-lon to cubed
sphere is faster than from gaussian.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#378 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKY5N2OPMLBYB7ENM73D2LLS2BKNVANCNFSM4WDNYA3Q>
.
--
*Fanglin Yang, Ph.D.*
*Chief, Model Physics Group*
*Modeling and Data Assimilation Branch*
*NOAA/NWS/NCEP Environmental Modeling Center*
*https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/
<https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>*
|
How difficult is it to create the equivalent lat-lon input file? Computing all those weights for interpolation from Gaussian to FV3 grid repeatedly over and over every time we initialize the model is unnecessary, and those computations are not trivial. |
|
Fanglin,
There is nothing wrong with the Gaussian grid. Is just as good as
lat/lon grid for the purpose it is used in sfcsub.
All sfcsub needs is high resolution, self describing data in grib1 format.
If one wants to change this one should rewrite sfcsub.
This code was originally created by late Dr. Kanamitsu when he was the
global branch chief at EMC
and I happen to have modified it to use in the forecast model.
Moorthi
On Fri, Jan 15, 2021 at 10:45 AM Fanglin Yang <[email protected]>
wrote:
… Dusan,
"global_slmask.t1534.3072.1536.grb" is on the Gaussian grid created many
years ago for the "old" GSM. It is so far the mask file of the highest
resolution we have that the model can use. Yes, at some point we should
get rid of all fixed fields on the Gaussian grid, but it takes time and
effort and coordinated effort is required.
Fanglin
On Fri, Jan 15, 2021 at 10:04 AM Dusan Jovic ***@***.***>
wrote:
> It does not matter what grid it is on as long as it is a grib1 file and
is
> high resolution. Moorthi
>
> Since it does not matter and FV3 is not spectral model, why don't we use
> regular lat-lon. I guess interpolating data from regular lat-lon to cubed
> sphere is faster than from gaussian.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <
#378 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AKY5N2OPMLBYB7ENM73D2LLS2BKNVANCNFSM4WDNYA3Q
>
> .
>
--
*Fanglin Yang, Ph.D.*
*Chief, Model Physics Group*
*Modeling and Data Assimilation Branch*
*NOAA/NWS/NCEP Environmental Modeling Center*
*https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/
<https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>*
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#378 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYT7YFBRWMZ2EO27MXLS2BPKHANCNFSM4WDNYA3Q>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: [email protected]
Phone: (301) 683-3718 Fax: (301) 683-3718
|
|
The weights are computed only once!
Moorthi
…On Fri, Jan 15, 2021 at 10:56 AM Dusan Jovic ***@***.***> wrote:
Dusan, "global_slmask.t1534.3072.1536.grb" is on the Gaussian grid created
many years ago for the "old" GSM. It is so far the mask file of the highest
resolution we have that the model can use. Yes, at some point we should get
rid of all fixed fields on the Gaussian grid, but it takes time and effort
and coordinated effort is required. Fanglin
How difficult is it to create the equivalent lat-lon input file? Computing
all those weights for interpolation from Gaussian to FV3 grid repeatedly
over and over every time we initialize the model is unnecessary, and those
computations are not trivial.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#378 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYVNKIKMZCTW2NTMCNTS2BQT5ANCNFSM4WDNYA3Q>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: [email protected]
Phone: (301) 683-3718 Fax: (301) 683-3718
|
|
Moorthi,
I was actually thinking of creating all fixed fields on the tiles for
supported resolutions to reduce the model initialization time and avoid
inconsistency. For GFS.v17 and GEFS.v13 the plan is to switch to use the
land boundary conditions on the tiles George created. There are only a few
other fields left to be processed.
For this particular case, my understanding is that the mask file is only
used for initializing lake temperature at certain points if no
climatologies exist.
Fanglin
On Fri, Jan 15, 2021 at 10:57 AM SMoorthi-emc <[email protected]>
wrote:
… Fanglin,
There is nothing wrong with the Gaussian grid. Is just as good as
lat/lon grid for the purpose it is used in sfcsub.
All sfcsub needs is high resolution, self describing data in grib1 format.
If one wants to change this one should rewrite sfcsub.
This code was originally created by late Dr. Kanamitsu when he was the
global branch chief at EMC
and I happen to have modified it to use in the forecast model.
Moorthi
On Fri, Jan 15, 2021 at 10:45 AM Fanglin Yang ***@***.***>
wrote:
> Dusan,
>
> "global_slmask.t1534.3072.1536.grb" is on the Gaussian grid created many
> years ago for the "old" GSM. It is so far the mask file of the highest
> resolution we have that the model can use. Yes, at some point we should
> get rid of all fixed fields on the Gaussian grid, but it takes time and
> effort and coordinated effort is required.
>
> Fanglin
>
> On Fri, Jan 15, 2021 at 10:04 AM Dusan Jovic ***@***.***>
> wrote:
>
> > It does not matter what grid it is on as long as it is a grib1 file and
> is
> > high resolution. Moorthi
> >
> > Since it does not matter and FV3 is not spectral model, why don't we
use
> > regular lat-lon. I guess interpolating data from regular lat-lon to
cubed
> > sphere is faster than from gaussian.
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub
> > <
>
#378 (comment)
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AKY5N2OPMLBYB7ENM73D2LLS2BKNVANCNFSM4WDNYA3Q
> >
> > .
> >
>
>
> --
> *Fanglin Yang, Ph.D.*
> *Chief, Model Physics Group*
> *Modeling and Data Assimilation Branch*
>
> *NOAA/NWS/NCEP Environmental Modeling Center*
>
> *https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/
> <https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>*
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <
#378 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ALLVRYT7YFBRWMZ2EO27MXLS2BPKHANCNFSM4WDNYA3Q
>
> .
>
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: ***@***.***
Phone: (301) 683-3718 Fax: (301) 683-3718
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#378 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKY5N2ON7HSG5NT5L7KFMK3S2BQXJANCNFSM4WDNYA3Q>
.
--
*Fanglin Yang, Ph.D.*
*Chief, Model Physics Group*
*Modeling and Data Assimilation Branch*
*NOAA/NWS/NCEP Environmental Modeling Center*
*https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/
<https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>*
|
Yes, Once every time we start the model. And computing those weight is more complicated than computing wights from lat-lon grid. Just look at how many nested loops are in la2ga subroutine. |
|
The time used for this is miniscule compared to all the other code
optimization that can be done.
Moorthi
…On Fri, Jan 15, 2021 at 11:14 AM Dusan Jovic ***@***.***> wrote:
The weights are computed only once! Moorthi
Yes, Once every time we start the model. And computing those weight is
more complicated than computing wights from lat-lon grid. Just look at how
many nested loops are in la2ga subroutine.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#378 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYR7MRZNC5ZGHKSGGVDS2BSWPANCNFSM4WDNYA3Q>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: [email protected]
Phone: (301) 683-3718 Fax: (301) 683-3718
|
junwang-noaa
added
the
Waiting for Reviews
climbfuji
reviewed
Jan 19, 2021
There was a problem hiding this comment.
Looks good. This PR addresses parts of step 4 of NOAA-EMC/fv3atm#214. Will approve once all testing is complete and the submodules are updated.
|
Fixed, thanks for finding the typo.
…On Fri, Jan 15, 2021 at 7:03 PM Denise Worthen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/tests/cpld_bmarkfrac_wave_v16
<#378 (comment)>
:
> @@ -148,6 +148,7 @@ export RUNID="cpcice"
export INPUT_NML=input.benchmark_v16.nml.IN
-export FIELD_TABLE="field_table.gfdlmp"
+export FIELD_TABLE="field_table_gfsv16"
+export DAIG_TABLE="diag_table_gfsv16"
This is a typo in DIAG not DAIG
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#378 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TIXQ2FA2J6BUSPASWLS2DJS3ANCNFSM4WDNYA3Q>
.
|
|
I merged the CMEPS changes but then noticed that we don't have a Hera gnu log. The baseline is there so I can run the test if needed. |
DeniseWorthen
approved these changes
Jan 20, 2021
DusanJovic-NOAA
approved these changes
Jan 20, 2021
climbfuji
approved these changes
Jan 20, 2021
This was referenced Jan 21, 2021
DomHeinzeller
pushed a commit
to NOAA-GSL/ufs-weather-model
that referenced
this pull request
Feb 23, 2021
* Updates to stochastic_physics_wrapper (ufs-community#280) Fix to stochastic_physics_wrapper to allow for random patterns to update at a longer time-step than model Co-authored-by: Dom Heinzeller <[email protected]> * Update for Jet, bug fixes in running with frac_grid=T and GFDL MP, and in restarting with frac_grid=T (ufs-community#304) Update the modulefile for jet.intel to enable UPP v10.0.0. The hpc-stack v1.0.0 pre-release is used for this. Small changes are made to tests.rt.sh for jet.intel and gaea.intel (consistency with other platforms). The submodule pointer update for fv3atm addresses bugs in the ufs-weather-model with frac_grid=T and GFDL microphysics, and with restarting the model when frac_grid=T (from @shansun6 and @SMoorthi-emc). * Feature/update mom6 and retain b4b results for 025x025 resolution (ufs-community#290) * point MOM6 to new branch which corresponding to GFDL 20201022 commit * modify fms_files.cmake and mom6_files.cmake to reflect changes in MOM6 code as this version of MOM6 contains some file deletion, new files being added and renaming of files * manually set MOM6 parameters in order to retain origonal results for 0.25x0.25 resolution * update MOM6 to include Bugfix for mom6solo to be built * modify compile.sh to allow mom6solo compiling * modify MOM_input_template for all resolutions based on GFDL MOM6-example main branch update on 20201022 * change executable permissions for CMakeLists.txt * chmod 644 to 6 files Dom pointed out * chmod for CMakeLists.txt and tests/compile.sh * change baseline directpory to 20201202 in rt.sh * Update CICE, Move regression test input outside baseline directory (ufs-community#270) *Updates CICE to most recent develop branch of NOAA-EMC * Sets n_aero (number of aerosols) in ice_in_template to 0. * removes trailing whitespace from ice_in * moves regression test input outside baseline directory (ufs-weather PR ufs-community#312) Co-authored-by: Dusan Jovic <[email protected]> Co-authored-by: Dom Heinzeller <[email protected]> * Updates to build for JEDI linking/control, add wcoss2 (ufs-community#295) * Build on wcoss2 (acorn) * Use -march=core-avx2 instead of -xCORE-AVX2 on wcoss2 * Updates to build for JEDI linking/control * Removed unnecessary include files and INLINE POST setting * Updated to address PR suggestions. * Add rt_acorn.conf. Change /lfs/h2 to /lfs/h1. * Update .gitmodules and submodule pointer for fv3atm for code review and testing * regression test results * Updated .gitmodules and removed extraneous file * Fixed .gitmodules and updated pointer for FV3 * Updated pointer to NEMS repo Co-authored-by: Dusan Jovic <[email protected]> Co-authored-by: Dom Heinzeller <[email protected]> * Final-final GFS v16 updates / restart reproducibility bugfixes (ufs-community#325) * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Add GFS v16 beta restart test, update stochastics test * Update regression test baseline date tag to 20201214; skip-ci * tests/rt.conf: bugfix, add missing 'fv3' to new stochy tests; skip-ci * Regression test logs for gaea.intel, hera.gnu, hera.intel, jet.intel, orion.intel; skip-ci * Run GFS v16beta tests also on wcoss; regression test logs for wcoss; skip-ci * Regression test logs for cheyenne.intel and cheyenne.gnu * Revert change to .gitmodules and update submodule pointer for fv3atm * Add optional bulk flux calculation in ufs-datm (ufs-community#266) * Update NEMS DATM and CMEPS to allow the optional bulk flux formulation; add two tests using the option * Update top level CMakeList.txt to have compile flags for MOM6 and CICE6 identical for ufs-cpld and ufs-datm * Add optional configuration variable to nems.configure to specify the directory where CMEPS will write restarts * Adds cheyenne tasking variables to default_vars and sets WW3_COMP to cheyenne for platform cheyenne.intel *NOTE: Baselines develop-20201215 exist on all platforms, regression tests were run against exactly that baseline on all systems except cheyenne.intel. On cheyenne.intel the tests were run against 20201214, and this baseline is identical to 20201215 (as per "diff -r develop-20201214 develop-20201215"). Co-authors: @DusanJovic-NOAA @aerorahul @JessicaMeixner-NOAA skip-ci * Add 2 new tests for DATM-MOM6-CICE6 application (ufs-community#332) * Add the following 2 tests: datm_restart_cfsr, datm_debug_cfsr * Add wcoss_dell_p3.log. * Add Hera log, Orion log, wcoss_dell_p3 log. * RRTMGP and Thompson MP coupling (ufs-community#323) * Feature branch with RRTMGP and Thompson MP * Updated FV3/ccpp-physics. Added namelist and configuration for RRTMGP RTs using GSD physics. * Updated FV3 * Update physics in FV3 * Updated baselines in rt.sh * Updated RT logs. Updated FV3 physics submodule pointer. * Updated FV3 hash and .gitmodules * Regression test log for PR ufs-community#323 for jet.intel (ufs-community#336) * Update modules with hpc-stack v1.1.0 (ufs-community#319) * Update modules with hpc-stack v1.1.0 * Minor bug fixes to CCPP UGWP Co-authored-by: Dom Heinzeller <[email protected]> * Replace old regional SDF with FV3_GFS_v15_thompson_mynn (ufs-community#333) * Replace old FV3_GFS_2017_gfdlmp_regional SDF for regional tests with FV3_GFS_v15_thompson_mynn. * Final path to IC's and new results. Also, input.nml updated. * Update RegressionTests_wcoss_dell_p3.log * Update RegressionTests_wcoss_cray.log * Update RegressionTests_hera.intel.log * Update RegressionTests_jet.intel.log * Update RegressionTests_orion.intel.log * Update RegressionTests_cheyenne* logs. * Update RegressionTests_hera.gnu.log * Feature/ww3update (ufs-community#334) This updates the WW3 submodule pointer to point to the top of the WW3 develop branch. The path to WW3 inputs is changed to input-data-20201201/WW3_input_data_20201207/ * Remove IPD (step 1) (ufs-community#331) Make CCPP=Y the default in tests/compile.sh. Remove CCPP=Y from tests/rt*.conf and adjust formatting. Update submodule pointer for MOM6 to include PR ufs-community#341 ("Update MOM6 to GFDL's 20201218 commit") Add modulefiles/wcoss_cray/fv3_debug (identical to modulefiles/wcoss_cray/fv3) Fix broken utest (see ufs-community#348) * Update the format of rt.conf (ufs-community#349) Update the format of MACHINES column in rt.conf (and other .conf files). This column can be either empty, which means a test will run on all supported machines, or start with - or + sign to exclude or include specified machines explicitly. * Add checkpoint restarts for ufs-cpld (ufs-community#342) * Adds 3 checkpoint restart tests for the ufs-cpld model * Drops the existing c92mx025 restart test * Adds cheyenne.intel as tested configuration for ufs-cpld and ufs-datm * Fixes instances of srf_data* in various fv3_conf files * add frac grid input, update and add additional cpld tests (ufs-community#354) * Updates FV3_input_frac to add both benchmark dates and L127 files * Adds additional tests and restart tests for coupled model * Sets all cpld tests to use frac grid input by default * Removes all instances of USE_LA_LI2016=True except for benchmark+wave configurations * Remove unnecessary SIMD instruction sets for Jet, first round of cleanup in rt.conf, initialize cld_amt to zero for regional runs (dycore) (ufs-community#353) * Reduce SIMDMULTIARCH sets from four to two in cmake/Intel.cmake * First cleanup of regression test config tests/rt.conf * tests/rt.sh: reduce number of build jobs on jet.intel from 10 to 5 * Remove flags -f and -s from rt.sh, remove SET logic, remove corresponding column in all rt*conf files * Remove tests/rt_acorn.conf and run GFS v15p2 and GFS v16beta DEBUG tests on all platforms * Implementation of CCPP timestep_init and timestep_final phases (ufs-community#337) * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Update submodule pointer for fv3atm; skip-ci * Don't try to compile all suites in DEBUG mode on cheyenne.intel, weird bug on compute nodes; skip-ci * Don't try to compile all suites in DEBUG mode on wcoss_cray; skip-ci * Regression test logs for cheyenne.gnu, cheyenne.intel, gaea.intel, hera.gnu, hera.intel, jet.intel, orion.intel; skip-ci * Don't try to compile all suites in DEBUG mode on wcoss_dell_p3; skip-ci * Regression test logs for wcoss_cray and wcoss_dell_p3 * Revert change to .gitmodules and update submodule pointer for fv3atm * Update CMEPS (ufs-community#345) * Update CMEPS for recent changes, including addition of new run "post" run phases to eliminate redundant mapping, multiple ice sheet capability and ocn->land ice dynamic mapping * Add a new test fv3_gfs_v16_RRTMGP_c192L127 Co-authored-by: Jun Wang <[email protected]> * Remove IPD steps 3 and 5 (ufs-community#357) Reduce SIMDMULTIARCH sets from four to two in cmake/Intel.cmake * First cleanup of regression test config tests/rt.conf * tests/rt.sh: reduce number of build jobs on jet.intel from 10 to 5; skip-ci * Remove flags -f and -s from rt.sh, remove SET logic, remove corresponding column in all rt*conf files * Update usage in rt.sh, add modulefiles/jet.intel/fv3_debug; skip-ci * CCPP is default in cmake build * Add debug modulefiles for linux.gnu and macosx.gnu * Update submodule pointer for fv3atm * Change logic in CMakeLists.txt and tests/compile.sh so that 32BIT=ON automatically sets DYN32=ON; skip-ci * Move logic to set DYN32 - depending on 32BIT setting - to fv3atm * Remove -DCCPP=ON from tests/compile.sh; update submodule pointer for fv3atm; skip-ci * point fv3 to EMC develop branch (ufs-community#377) * update cpl gfsv16 tests, rrtmgp fix and bug fixes in cmeps (ufs-community#378) * update CMEPS, fix character length error for gnu compile * add Dusan's fix for rt_utils.sh * update cpl gfsv16 tests, replace seaice_newland.grb with global_slmask.t1534.3072.1536.grb, recover input.mom6.nml.IN, update input directory, update global thread and decomp tests, update fdiag for global control * point to Dustins rrtmgp fix branch * update input directory Co-authored-by: denise.worthen <[email protected]> Co-authored-by: Jun Wang <[email protected]> * Update develop from NOAA-GSL: RUC ice, MYNN sfclay, stochastic land perturbations (ufs-community#386) * Update .gitmodules and submodule pointer for fv3atm for gsl/develop branch * RUC ice for gsl/develop (replaces #47) (#49)Implementation of RUC LSM ice model in CCPP * Squash-merge climbfuji:rucice_gfsv16dzmin into gsl/develop * Add kice=9 to tests/tests/fv3_ccpp_rap and tests/tests/fv3_ccpp_hrrr * Change NEW_BASELINE directory for gsl/develop to avoid conflicts with development work on the authoritative branches * Add KICE=9 to tests/tests/fv3_ccpp_gsd_unified_ugwp and tests/tests/fv3_ccpp_gsd_drag_suite_unified_ugwp * Revert change to .gitmodules and update submodule pointer for fv3atm * Update gsl/develop from develop 2020/12/08 (#50) * Updates to stochastic_physics_wrapper (ufs-community#280) Fix to stochastic_physics_wrapper to allow for random patterns to update at a longer time-step than model * Update for Jet, bug fixes in running with frac_grid=T and GFDL MP, and in restarting with frac_grid=T (ufs-community#304) Update the modulefile for jet.intel to enable UPP v10.0.0. The hpc-stack v1.0.0 pre-release is used for this. Small changes are made to tests.rt.sh for jet.intel and gaea.intel (consistency with other platforms). The submodule pointer update for fv3atm addresses bugs in the ufs-weather-model with frac_grid=T and GFDL microphysics, and with restarting the model when frac_grid=T (from @shansun6 and @SMoorthi-emc). * Land stochastic perturbations (#57) * dycore options to add zero-gradient BC to reconstruct interface u/v and change dz_min as input (ufs-community#369) * Update fv3atm * update ccpp control test forecast length to 24h * remove rename command * Add CI related changes * Update RT logs * Update RT log files * Add the gaea RT log file * Update the point of fv3atm * Update fv3atm Co-authored-by: Jun Wang <[email protected]> Co-authored-by: MinsukJi-NOAA <[email protected]> Co-authored-by: Jun Wang <[email protected]> * MOM6 bugfixes, GFDL update, update CDMBGWD settings; fix for restart reproducibility (without waves) when USE_LA_LI2016=True, sign error on fprec passed to ocean, GFDL update, resolution dependent cdmbgwd settings (ufs-community#379) * implements two MOM6 bugfixes in the NUOPC MOM6 cap to allow restart reproducibility when USE_LA_LI2016=True and to change the sign of the latent heat flux associated with frozen precipitation (fprec) exported to MOM6 * updates MOM6 to include the GFDL 20210120 main branch which contains EMC's wave coupling code, alone with some minor code standardization and documentation * updates the cdmbgwd namelist settings for FV3 standalone tests at C96 and implements resolution dependent values for ufs-cpld tests Co-authored-by: Ali <[email protected]> * Remove legacy gnumake build from fv3atm and NEMS, remove legacy Python 2.7 support, rename v16beta to v16 and RT updates (ufs-community#384) * Update .gitmodules and submodule pointers for fv3atm and NEMS * Remove Python 2.7 support from top-level CMakeLists.txt * Reduce forecast length of test fv3_ccpp_gfs_v16_RRTMGP_c192L127 from 24h to 12h * Rename v16beta to v16 everywhere except the public release documentation * Bugfixes and missing changes * Remove 'export CCPP_LIB_DIR=ccpp/lib' from all regression tests * Update regression test baseline date tag to 20210128; skip-ci * Update ecflow-python environment on cheyenne and jet; skip-ci * Update CMEPS for HAFS integration; add datm and coupled-model tests on Gaea (ufs-community#401) * Add HAFS support in NOAA-EMC/CMEPS * Add coupled and datm tests for Gaea.intel Co-authored-by: Jun Wang <[email protected]> Co-authored-by: Bin Li <[email protected]> * Move LSM vegetation lookup tables into CCPP, clean up RUC snow cover on ice initialization (remove IPD step 2) (ufs-community#407) * Regression test logs for all tier=1 platforms * updates FMS to 2020.04.01 (ufs-community#392) * updates FMS to 2020.04.01 * fixes fms_files.cmake * removes extra horiz_interp * Workaround for FMS 2020.04.01 for Cheyenne with GNU 9.1.0, incl. regression test log Co-authored-by: Mikyung Lee <[email protected]> Co-authored-by: Dom Heinzeller <[email protected]> * add optional mesh in MOM6; add dz_min and min_seaice as configurable variables for coupled model (ufs-community#399) *Implements an optional setting in the cpld and datm nems.configure files to specify whether the MOM6 cap should use a mesh or a grid *Adds configurable settings for min_seaice to gfs_physics_nml and dz_min to fv_core_nml. * UGWP v0 v1 combined (ufs-community#396) - combines the changes in PRs ufs-community#360 and ufs-community#382 - adds three regression tests `fv3_ccpp_gfsv16_ugwpv1 `, `fv3_ccpp_gfsv16_ugwpv1_warmstart` and `fv3_ccpp_gfsv16_ugwpv1_debug` - contains updates and bugfixes for `nc_compare.py` and the CI tests from @MinsukJi-NOAA - update Python3 environment on jet.intel, gaea.intel, cheyenne.{intel,gnu} - turn off (again) test `fv3_ccpp_decomp` on jet.intel, this test didn't work in the past, but recently it "passed", because the error checking with `nc_compare.py` failed silently and we didn't notice it Co-authored-by: valery.yudin <[email protected]> Co-authored-by: Michael Toy <[email protected]> Co-authored-by: MinsukJi-NOAA <[email protected]> * Update regression tests from GFSv15+Thompson to GFSv16+Thompson, include "Add one regional regression test in DEBUG mode. (ufs-community#419)" (ufs-community#421) * Add one regional regression test in DEBUG mode. * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Update regression tests from GFSv15+Thompson to GFSv16+Thompson * Combine several COMPILE lines in tests/rt.conf and tests/rt_gnu.conf * Regression test log for cheyenne.{gnu,intel},gaea.intel, hera.gnu, jet.intel,hera.intel,orion.intel;wcoss_cray and wcoss_dell_p3; Co-authored-by: Phil Pegion <[email protected]> Co-authored-by: jiandewang <[email protected]> Co-authored-by: Denise Worthen <[email protected]> Co-authored-by: Dusan Jovic <[email protected]> Co-authored-by: Mark Potts <[email protected]> Co-authored-by: BinLi-NOAA <[email protected]> Co-authored-by: dustinswales <[email protected]> Co-authored-by: Kyle Gerheiser <[email protected]> Co-authored-by: RatkoVasic-NOAA <[email protected]> Co-authored-by: Ali.Abdolali <[email protected]> Co-authored-by: Jun Wang <[email protected]> Co-authored-by: Jun Wang <[email protected]> Co-authored-by: XiaqiongZhou-NOAA <[email protected]> Co-authored-by: Ali <[email protected]> Co-authored-by: Bin Li <[email protected]> Co-authored-by: MiKyung Lee <[email protected]> Co-authored-by: valery.yudin <[email protected]> Co-authored-by: Michael Toy <[email protected]> Co-authored-by: MinsukJi-NOAA <[email protected]>
AnningCheng-NOAA
added a commit
to AnningCheng-NOAA/ufs-weather-model
that referenced
this pull request
Mar 8, 2021
* upstream/develop: update MOM6 to GFDL 20210224 main branch commit (ufs-community#439) Add GNU and Cheyenne Support to Automated RT (ufs-community#444) Move Noah MP init to CCPP and update Noah MP regression tests, ice flux init bug fix in CCPP (ufs-community#425) Feature/rt automation (ufs-community#403) Update ccpp-physics. Make RRTMGP thread safe (ufs-community#418) Update regression tests from GFSv15+Thompson to GFSv16+Thompson, include "Add one regional regression test in DEBUG mode. (ufs-community#419)" (ufs-community#421) UGWP v0 v1 combined (ufs-community#396) add optional mesh in MOM6; add dz_min and min_seaice as configurable variables for coupled model (ufs-community#399) updates FMS to 2020.04.01 (ufs-community#392) Move LSM vegetation lookup tables into CCPP, clean up RUC snow cover on ice initialization (remove IPD step 2) (ufs-community#407) Update CMEPS for HAFS integration; add datm and coupled-model tests on Gaea (ufs-community#401) Remove legacy gnumake build from fv3atm and NEMS, remove legacy Python 2.7 support, rename v16beta to v16 and RT updates (ufs-community#384) MOM6 bugfixes, GFDL update, update CDMBGWD settings; fix for restart reproducibility (without waves) when USE_LA_LI2016=True, sign error on fprec passed to ocean, GFDL update, resolution dependent cdmbgwd settings (ufs-community#379) dycore options to add zero-gradient BC to reconstruct interface u/v and change dz_min as input (ufs-community#369) Update develop from NOAA-GSL: RUC ice, MYNN sfclay, stochastic land perturbations (ufs-community#386) update cpl gfsv16 tests, rrtmgp fix and bug fixes in cmeps (ufs-community#378) point fv3 to EMC develop branch (ufs-community#377) Remove IPD steps 3 and 5 (ufs-community#357) Update CMEPS (ufs-community#345) Implementation of CCPP timestep_init and timestep_final phases (ufs-community#337) Remove unnecessary SIMD instruction sets for Jet, first round of cleanup in rt.conf, initialize cld_amt to zero for regional runs (dycore) (ufs-community#353) add frac grid input, update and add additional cpld tests (ufs-community#354) Add checkpoint restarts for ufs-cpld (ufs-community#342) Update the format of rt.conf (ufs-community#349) Remove IPD (step 1) (ufs-community#331) Feature/ww3update (ufs-community#334) Replace old regional SDF with FV3_GFS_v15_thompson_mynn (ufs-community#333) Update modules with hpc-stack v1.1.0 (ufs-community#319) Regression test log for PR ufs-community#323 for jet.intel (ufs-community#336) RRTMGP and Thompson MP coupling (ufs-community#323) Add 2 new tests for DATM-MOM6-CICE6 application (ufs-community#332) Add optional bulk flux calculation in ufs-datm (ufs-community#266) Final-final GFS v16 updates / restart reproducibility bugfixes (ufs-community#325) Updates to build for JEDI linking/control, add wcoss2 (ufs-community#295) Update CICE, Move regression test input outside baseline directory (ufs-community#270) Feature/update mom6 and retain b4b results for 025x025 resolution (ufs-community#290) Update for Jet, bug fixes in running with frac_grid=T and GFDL MP, and in restarting with frac_grid=T (ufs-community#304) Updates to stochastic_physics_wrapper (ufs-community#280) Update develop from gsd/develop 2020/11/20: Unified gravity wave drag, updates to other GSL physics (ufs-community#297) Fix to allow quilting with non-factors for layout (ufs-community#250) rt update (ufs-community#261)
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
## DESCRIPTION OF CHANGES: Part of the effort described in ufs-community/ufs-srweather-app#71 to update the master branch of ufs-srweather-app to a functioning state. Updates include: - Cherry-picking 10911bcb from release branch in order to include the RRFS_v1alpha CCPP suite, as well as fixing some updated namelist settings in the ufs-weather-model - Fixing other namelist options that have been updated in ufs-weather-model This PR must be merged prior to ufs-community/ufs-srweather-app#71, then that PR updated to point to this PR's hash. ## TESTS CONDUCTED: The following end-to-end tests are now all successful on Hera: - DOT_OR_USCORE - GST_release_public_v1 - get_extrn_files_from_hpss_FV3GFS_FV3GFS - get_extrn_files_from_hpss_GSMGFS_GSMGFS - get_extrn_files_from_hpss_HRRR_RAP - get_extrn_files_from_hpss_RAP_RAP - grid_GSD_HRRR_AK_50km - grid_GSD_RAP13km - grid_RRFS_AK_13km_FV3GFS_FV3GFS - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - grid_RRFS_CONUS_13km_ics_HRRR_lbcs_RAP_suite_GSD_SAR - grid_RRFS_CONUS_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_GSD_SAR - grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta - new_ESGgrid - new_GFDLgrid - new_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_FALSE - new_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_TRUE - regional_001 - regional_002 - suite_FV3_GFS_v15p2 - suite_FV3_GFS_v16beta - suite_FV3_GSD_SAR - suite_FV3_GSD_v0 - suite_FV3_RRFS_v1beta The following end-to-end tests were successful on Jet: - DOT_OR_USCORE - get_extrn_files_from_hpss_FV3GFS_FV3GFS - get_extrn_files_from_hpss_GSMGFS_GSMGFS - get_extrn_files_from_hpss_HRRR_RAP - get_extrn_files_from_hpss_RAP_RAP - grid_RRFS_AK_13km_FV3GFS_FV3GFS - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16beta - new_ESGgrid - new_GFDLgrid - new_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_FALSE - regional_001 - regional_002 - suite_FV3_GFS_v16beta A few tests on Hera and Jet are still failing, but they are known errors and will be fixed at a later date. Cheyenne tests are failing but this is fixed by #378 ## ISSUE (optional): In conjunction with #378 and ufs-community/ufs-srweather-app#71, will solve ufs-community/ufs-srweather-app#57, fixing the master branch of ufs-srweather-app so everyone will be happy and nothing will be broken and we will all live happily ever after.
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
…heyenne, as well as fix workflow generation on Cheyenne (#378) ## DESCRIPTION OF CHANGES: A fix was applied to the release branch for the Cheyenne workflow and automated testing in #343, this PR applies the same to develop. ## TESTS CONDUCTED: Workflow built and ran on Cheyenne; the following tests were run and all passed: - grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 - grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 ## ISSUE (optional): Fully resolves #326
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Combine CI infrastructure, use get_expts_status etc to simplify Jenkins. * Unload python in wflow_cheyenne just to be safe. * Don't do launch_wflow when checking experiment status. * Debug post test tar failures on Cheyenne * Disable PW AWS cluster for pipeline * Fake un-launched jobs as if they are in progress. * Undo last commit. * Increase cron interval to 5 mins. * Also increase initial delay to 6 min. * Fix variable expansion for the srw_test.sh call * Updates for build artifact handling * Update tar command to create cleaner artifact * Update path of build log for s3 upload * Remove lines used for debugging * Remove custom test list. * Add custom_ensemble_2mems_stoch. * Undo unloading of python for Cheyenne. * debug cheyenne python failures * Add more debugging code for cheyenne. * Decrease re-launch interval temporarily. * Turn off check_var_valid. * Add Lmod_init for Gaea. * Clean up now that everything seems to work. * Fix comment about the need for conda activation for Cheyenne. * Print crontab content before/after deletion. * Improve experiments directory clean up Only remove the data directories to allow we2e cron jobs to complete and clean up themselves correctly. * Ensure we2e cron jobs execute again before cleanup * Bug fix in build.sh. Co-authored-by: Jesse McFarland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is going to
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
The test is running on hera. Will be tested on all other platforms.
Dependencies
Related PRs:
CCPP PR#548
fv3atm PR#237
CMEPS PR#31
ufs-weather-model PR#378