Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CCPP suites to non-meaningful names #2317

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

mkavulich
Copy link

@mkavulich mkavulich commented Jun 10, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR renames CCPP suites to non-meaningful names, per discussions among CCPP and weather model developers. In this initial round, we have arbitrarily settled on bird names, and they were semi-randomly assigned as suggested by various colleagues and ChatGPT. The only non-random naming was that the names for corresponding suites in the Single Column Model repository were made identical: see that PR for more information.

Attempts were made to avoid confusing or ambiguous names, but suggestions are welcome as these names are not set in stone. The whole point of this renaming is that the suite names should be insignificant, only serving to disambiguate different physics configurations. Scientific and technical information about the suites should be derived from the suite file contents and other documentation.

Speaking of documentation, the Users Guide has been updated for the new names, and now contains a lot more information about CCPP suite files. Most helpfully, there is a complete table of CCPP SDFs that are used in regression tests here: https://ufs-weather-model-mkavulich.readthedocs.io/en/latest/InputsOutputs.html#the-suite-definition-file-sdf-file

Commit Message:

* UFSWM - Renaming CCPP Physics suites to non-meaningful names
  * FV3 - Renaming CCPP Physics suites to non-meaningful names
    * ccpp-framework - Remove requirement that suite definition file names begin with "suite_"

Priority:

  • High: Should be merged prior to CCCP v7 release.

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

     - Update FV3 hash
     - Replace old suite names in test files
     - Updating some documentation for new suite names
@mkavulich mkavulich changed the title Feature/suite names update Rename CCPP suites to non-meaningful names Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant