Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WCOSS2 libraries for spack-stack 1.6.0 (Combined PR #2301) #2302

Merged
merged 27 commits into from
May 31, 2024
Merged

Update WCOSS2 libraries for spack-stack 1.6.0 (Combined PR #2301) #2302

merged 27 commits into from
May 31, 2024

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented May 30, 2024 •
edited
Loading

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR brings in the necessary changes to match the libraries set for Spack-Stack 1.6.0

  • ESMF 8.6.0
  • FMS 2024.03
  • pnetcdf 1.12.2
  • MAPL - 2.40.3 to use ESMF 8.6.0

This PR also merged with #2301 which are miscellaneous changes to rt.sh to address a few issues related to the new verbose setting and cleaned up wording on failed tests.

Commit Message:

* UFSWM
  * Bring in changes for WCOSS2 to match the spack-stack 1.6.0 setup
  * Bring in updated pnetcdf/pio for CICE
  * Small rt.sh changes to improve verbosity and wording on test failures.

Priority:

  • High: Needed for spack-stack 1.6.0 and pnetcdf/pio upgrades

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.
    • this test is only changing on WCOSS2 not any other platforms (cpld_control_gfsv17_iau_intel).

Input data Changes:

  • None.

Library Changes/Upgrades:

  • Updates already completed.

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

DusanJovic-NOAA and others added 12 commits May 16, 2024 14:48
@DusanJovic-NOAA
Print 'ECFLOW Tasks Remaining' message only when the number of tasks …
49857ec 
…changes
@DusanJovic-NOAA
Remove explicit 'set -e'. Use -v command line option for verbose mode
13139a7
@DusanJovic-NOAA
Remove 'Computing PET bounds and tasks' message
2ca46a6
@DusanJovic-NOAA
Uncomment new_compile=true in rocoto_create_compile_task
5da94e0
@BrianCurtis-NOAA
remove special case for hdf5 format for CICE history/restart
655f8e6
@BrianCurtis-NOAA
Merge branch 'develop' of github.com:ufs-community/ufs-weather-model …
a3f6974 
…into develop
@BrianCurtis-NOAA
Merge branch 'develop' of github.com:ufs-community/ufs-weather-model …
b6aaf45 
…into develop
@BrianCurtis-NOAA
Fix bugs with log generation script (ufs-community#40)
314a340 
* Update wording on failed tests/compiles, added skipped tests when compile fails and math adjustments, adjusted grep for TIME LIMIT when a compile/test times out.
* removed commented lines and added TIME LIMIT to test section as well
* edit log file info for timeout tests
@DusanJovic-NOAA
Merge remote-tracking branch 'origin/develop' into random_rt_fixes
04cdfeb
@DusanJovic-NOAA
Removed unneded colonifnco
31d2e01
@BrianCurtis-NOAA
get clibs working, disable atml tests, remove temporary workaround fo…
e05dab3 
…r pio/netcdf
@BrianCurtis-NOAA
bump cray mpich to 8.1.12
2582804
@BrianCurtis-NOAA
Copy link
Collaborator Author

@jkbk2004 Since this is strictly a WCOSS2 PR, we should be able to skip testing on all other platforms. This should make this PR go quick enough we might be able to fit both spack PR's back to back in the same day.

@BrianCurtis-NOAA
Copy link
Collaborator Author

OK @jkbk2004 since I have only added rt.sh changes from Dusan, it would be good to have a sanity check on Hera full suite. Could your team run that? I will get WCOSS2 RT suite started now, and probably completed later this evening.

@zach1221
Copy link
Collaborator

OK @jkbk2004 since I have only added rt.sh changes from Dusan, it would be good to have a sanity check on Hera full suite. Could your team run that? I will get WCOSS2 RT suite started now, and probably completed later this evening.

I'll run on Hera.

@BrianCurtis-NOAA
Copy link
Collaborator Author

Since WCOSS2 does have a test change, we will need a new bl_date, but with the RDHPCS systems we can just create a symlink to the previous develop-date.

@FernandoAndrade-NOAA FernandoAndrade-NOAA added the Baseline Updates Current baselines will be updated. label May 30, 2024
@zach1221
Copy link
Collaborator

RegressionTest_hera.log

@zach1221 zach1221 changed the title Update WCOSS2 libraries for spack-stack 1.6.0 Update WCOSS2 libraries for spack-stack 1.6.0 (Combined PR #2301) May 31, 2024
@zach1221 zach1221 added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. hera-RT Run Hera regression testing hercules-RT Run Hera regression testing orion-RT derecho-RT Run regression tests on Derecho and removed hera-RT Run Hera regression testing hercules-RT Run Hera regression testing orion-RT labels May 31, 2024
@zach1221 zach1221 removed the derecho-RT Run regression tests on Derecho label May 31, 2024
@jkbk2004 jkbk2004 mentioned this pull request May 31, 2024
Merged
41 tasks
@BrianCurtis-NOAA
Copy link
Collaborator Author

@jkbk2004 @zach1221 we are ready for merge.

@zach1221
Copy link
Collaborator

@jkbk2004 @zach1221 we are ready for merge.

@BrianCurtis-NOAA Ok, do you not want the ORT logs? They're almost finished. Either way is fine with me.

@BrianCurtis-NOAA
Copy link
Collaborator Author

@jkbk2004 @zach1221 we are ready for merge.

@BrianCurtis-NOAA Ok, do you not want the ORT logs? They're almost finished. Either way is fine with me.

Yes, thats fine. I did forget about those.

@zach1221
Copy link
Collaborator

@DusanJovic-NOAA @jkbk2004 Ok, we're ready for final review at this time.

@zach1221 zach1221 merged commit 5bec704 into ufs-community:develop May 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkbk2004 jkbk2004 jkbk2004 approved these changes

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

Assignees
No one assigned
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Milestone
No milestone
6 participants
@BrianCurtis-NOAA @zach1221 @jkbk2004 @DusanJovic-NOAA @FernandoAndrade-NOAA @epic-cicd-jenkins