Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update inputdata for Bu angle fix; re-enable cpld C48 warmstart test #2235

Merged
merged 25 commits into from
May 7, 2024

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Apr 12, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers. NA
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Creates a new input-data directory to account for Bu angle fix for CICE and re-enabling cpld C48 tests. The following files or directories are updated:

./CICE_FIX/500/grid_cice_NEMS_mx500.nc
./CICE_FIX/500/kmtu_cice_NEMS_mx500.nc
./CICE_FIX/100/grid_cice_NEMS_mx100.nc
./CICE_FIX/100/kmtu_cice_NEMS_mx100.nc
./CICE_FIX/025/grid_cice_NEMS_mx025.nc
./CICE_FIX/025/kmtu_cice_NEMS_mx025.nc
./CICE_FIX/050/grid_cice_NEMS_mx050.nc
./CICE_FIX/050/kmtu_cice_NEMS_mx050.nc

./CICE_FIX/500/mesh.mx500.nc
./CICE_FIX/100/mesh.mx100.nc
./CICE_FIX/025/mesh.mx025.nc
./CICE_FIX/050/mesh.mx050.nc

./FV3_input_data48/INPUT_L127_mx500/2021032306
./MOM6_IC/500/2021032306
./CICE_IC/500/2021032306
./CMEPS_IC/C48mx500/2021032306

The following files or directories are removed

./CPL_FIX/aC48o400
./FV3_input_data48/INPUT_L127_mx400
./MOM6_FIX/400
./lake_p8_water_fraction2020/oro_C48.mx400.tile4.nc
./lake_p8_water_fraction2020/oro_C48.mx400.tile5.nc
./lake_p8_water_fraction2020/oro_C48.mx400.tile1.nc
./lake_p8_water_fraction2020/oro_C48.mx400.tile3.nc
./lake_p8_water_fraction2020/oro_C48.mx400.tile6.nc
./lake_p8_water_fraction2020/oro_C48.mx400.tile2.nc
./FV3_fix_tiled/C48/oro_C48.mx400.tile4.nc
./FV3_fix_tiled/C48/oro_C48.mx400.tile5.nc
./FV3_fix_tiled/C48/oro_C48.mx400.tile1.nc
./FV3_fix_tiled/C48/oro_C48.mx400.tile3.nc
./FV3_fix_tiled/C48/oro_C48.mx400.tile6.nc
./FV3_fix_tiled/C48/oro_C48.mx400.tile2.nc
./CICE_IC/400
./CICE_FIX/400
./CICE_FIX/400/grid_cice_NEMS_mx400.nc
./CICE_FIX/400/kmtu_cice_NEMS_mx400.nc
./CICE_FIX/400/mesh.mx400.nc

Note the mesh files are not directly impacted by the Bu angle bug, but during development of the fix, the 360. deg increment added to the MOM6 longitudes was removed. This results in a change of the mesh file longitude coordinate.

The updated files were copied from the UFS-UTILS baseline directory that was created by ufs-community/UFS_UTILS#922. See related issue ufs-community/UFS_UTILS#921

A new input data directory has been staged on Hera at /scratch1/NCEPDEV/stmp4/Denise.Worthen/input-data_20240501 and will need to be sync'd across all platforms.

This staged input directory also removes the files related to the "400" ocean resolution. These are currently unused, and and simply copies of the "500" directories. This is because when the files were originally made, the wrong name string was used. We have never had a 4-deg ocean resolution.

It also updates the warmstart files required to re-enable the C48-5deg warmstart and restart from warmstart RTs.

Commit Message:

* UFSWM - update input data directory to fix CICE grid files for incorrect Bu angle, update C48 coupled warmstart files and remove 4-deg ocean files

Priority:

  • Normal.

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • Updated input data.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@DeniseWorthen DeniseWorthen added Baseline Updates Current baselines will be updated. New Input Data Req'd This PR requires new data to be sync across platforms labels Apr 12, 2024
@DeniseWorthen DeniseWorthen changed the title update inputdata for Bu angle fix update inputdata for Bu angle fix; re-enable cpld C48 warmstart test Apr 17, 2024
@DeniseWorthen DeniseWorthen added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Apr 18, 2024
@DeniseWorthen
Copy link
Collaborator Author

@jkbk2004 Why does the new input-data-20240501 on hera still contain files for "400" resolution? If the directory had been sync'd directly from my staged input, there would be no 400 files present.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 2, 2024

@jkbk2004 Why does the new input-data-20240501 on hera still contain files for "400" resolution? If the directory had been sync'd directly from my staged input, there would be no 400 files present.

Check now: /scratch2/NAGAPE/epic/UFS-WM_RT/NEMSfv3gfs/input-data-20240501

@DeniseWorthen
Copy link
Collaborator Author

These files are still present: ./lake_p8_water_fraction2020/oro_C48.mx400.tile[1-4].nc

Did you rsync directly from my staged input-data. That is the requirement.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 2, 2024

These files are still present: ./lake_p8_water_fraction2020/oro_C48.mx400.tile[1-4].nc

Did you rsync directly from my staged input-data. That is the requirement.

I need sysn admins hep to remove those lake oro (400) files. All others were resynced ok.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 2, 2024

These files are still present: ./lake_p8_water_fraction2020/oro_C48.mx400.tile[1-4].nc
Did you rsync directly from my staged input-data. That is the requirement.

I need sysn admins help to remove those lake oro (400) files. All others were resynced ok.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented May 2, 2024

all good now: /scratch2/NAGAPE/epic/UFS-WM_RT/NEMSfv3gfs/input-data-20240501

@FernandoAndrade-NOAA
Copy link
Collaborator

Gaea and Jet rsync looks good to go.

@zach1221
Copy link
Collaborator

zach1221 commented May 3, 2024

Gaea and Jet rsync looks good to go.

Derecho, orion and hercules should be good as well. @jkbk2004 @BrianCurtis-NOAA I think we'll move to start working this PR since we're skipping Jun's for now.

@zach1221
Copy link
Collaborator

zach1221 commented May 3, 2024

@DeniseWorthen are you able to update the INPUTDATA_ROOT date to 20240501, or are you ok with me making the change?

@DeniseWorthen
Copy link
Collaborator Author

@zach1221 Please update it. Thanks.

@FernandoAndrade-NOAA
Copy link
Collaborator

Leaving a note that Hera timed out on the regional_atmaq_debug_intel case, rerunning without limit increase first. Gaea seems to have stopped rt.sh during the tracking of remaining tasks stage, rerunning that as well.

tests/rt.sh Outdated Show resolved Hide resolved
@BrianCurtis-NOAA
Copy link
Collaborator

Acorn will not be ready in a reasonable time, please skip.

@zach1221
Copy link
Collaborator

zach1221 commented May 7, 2024

@BrianCurtis-NOAA @jkbk2004 we are ready for final review.

@zach1221 zach1221 merged commit 223b9ae into ufs-community:develop May 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. New Input Data Req'd This PR requires new data to be sync across platforms Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grid files used by CICE contain incorrect rotation angle re-enable c48-5deg warmstart test
5 participants