Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for optional arguments in ccpp physics and framework AND add end of run restart functionality to MOM6 (was #2286) #2205

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Mar 22, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step
    • I couldn't - test_changes.list was empty from previous PR, and since my PRs don't change results I can't commit an unmodified file (see 5588f99)

Description:

This set of PRs adds support for optional arguments in CCPP physics schemes to the metadata and framework, with related changes in fv3atm, gfdl_atmos_cubed_sphere, and stochastic_physics.

From 2286:
This PR allows the user to create restart files at the end of a run in MOM using the write_restart_at_endofrun configuration option in CMEPS.

Commit Message:

* UFSWM - Add support for optional arguments in ccpp physics and framework 
  * FV3 - [Add support for optional arguments in ccpp physics and framework](https://github.com/NOAA-EMC/fv3atm/pull/807#top)
    * ccpp-physics - Introduce optional arguments in ccpp schemes and metadata
    * ccpp-framework - Add support (and tests) for optional arguments in ccpp_prebuild
    * atmos_cubed_sphere - Set cdata%thrd_cnt in driver/fvGFS/atmosphere.F90
  * MOM6 - Add end of run restart functionality to MOM6
  * stochastic_physics - Add optional attribute for variables where necessary

Priority:

  • High: Timeline - my transition to NRL (selfish, I know, sorry) and another large set of PRs (conversion to contiguous arrays) waiting for these changes

Git Tracking

UFSWM Issues:

Sub component Pull Requests:

This is part of a large set of PRs:

UFSWM Blocking Dependencies:

  • None.

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes - everything is bit-for-bit identical!

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

…v3atm: scale lightning threat indices from flashes per 5 minutes to flashes per minute, and then back to flashes per 5 minutes
…r-model into feature/ccpp_framework_merge_feature_capgen_into_main_20240308
…r-model into feature/ccpp_framework_merge_feature_capgen_into_main_20240308
… pointer for stochastic_physics for code review and testing
@zach1221 zach1221 added hercules-RT Run Hera regression testing and removed hercules-RT Run Hera regression testing labels May 21, 2024
@BrianCurtis-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA can you bring in the PR information from the combined PR into this one?

@FernandoAndrade-NOAA
Copy link
Collaborator

Ok, we should be all set to continue the merge process, I'll leave a note on the component PRs.

@jiandewang
Copy link
Collaborator

Ok, we should be all set to continue the merge process, I'll leave a note on the component PRs.

time ot merge MOM6 ?

@FernandoAndrade-NOAA
Copy link
Collaborator

Ok, we should be all set to continue the merge process, I'll leave a note on the component PRs.

time ot merge MOM6 ?

Yes please go ahead and merge in MOM6, we should be all set there.

@jiandewang
Copy link
Collaborator

just merged MOM6. Hash # b32aea7bf3

@climbfuji
Copy link
Collaborator Author

fv3atm should be ready to merge, please check

@FernandoAndrade-NOAA
Copy link
Collaborator

fv3atm should be ready to merge, please check

All component PRs merged in, please go ahead and revert gitmodules / update hashes, thanks!

@climbfuji
Copy link
Collaborator Author

Thanks for shepherding this PR set through - should be good to go

@FernandoAndrade-NOAA FernandoAndrade-NOAA merged commit 635890c into ufs-community:develop May 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add writing end of run restart file in MOM6
9 participants