Updating FV3 for moving nest land mask improvements

[wramstrom]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full RT suite (compared to current baselines) on either Hera/Derecho/Hercules AND have committed the log to my PR branch.
• Add list of all failed regression tests in "Regression Tests" section.

PR Information

Description

Makes handling of land-sea mask more accurate along coastlines and for initial nest location; these changes also carry over to other land surface variables. For most domains, zero to only a few points will have changes; expect that forecast accuracy will not be affected, but these changes may prevent some of the HAFS model crashes that were seen in 2023.

Also needs to incorporate branch with changes to exhafs_forecast.sh script to create symbolic links in INPUT/moving_nest directory needed for moving nest land mask improvements.

Commit Message

Upgrade to moving nest land mask handling for improved stability of the model.

Priority

• Critical Bugfix (This PR contains a critical bug fix and should be prioritized.)
• High (This PR contains a feature or fix needed for a time-sensitive project (eg, retrospectives, implementations))
  • Needed by HAFSv2 code freeze (targeting end of January, 2024)
• Normal

Blocking Dependencies

Git Issues Fixed By This PR

Closes NOAA-EMC/fv3atm/issues/763

Changes

Subcomponent (with links)

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
  • Improve moving nest land mask handling NOAA-EMC/fv3atm#772
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Input data

• No changes are expected to input data.
• Changes are expected to input data:
  • New input data.
  • Updated input data.

Regression Tests:

Changes may occur in HAFS regression tests. All other tests should have no changes.

• No changes are expected to any regression test.
• Changes are expected to the following tests:

FAILED REGRESSION TESTS

Result changing is only expected for the HAFS moving nesting related regression tests.

Libraries

• Not Needed
• Needed
  • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
  • Add issue link from JCSDA/spack-stack following this item

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[github-actions]

@hafs-community please bring these up to date with respective authoritative repositories

• ufs-weather-model NOT up to date
• mom6 NOT up to date
• ww3 NOT up to date

[BinLiu-NOAA]

After communicating with @wramstrom and others, we will not include these changes in HAFSv2 code freeze. Thus, we will hold this PR for now.

[BinLiu-NOAA]

After communicating with @wramstrom and others, we will not include these changes in HAFSv2 code freeze. Thus, we will hold this PR for now.

@jkbk2004 @FernandoAndrade-NOAA FYI.

[FernandoAndrade-NOAA]

After communicating with @wramstrom and others, we will not include these changes in HAFSv2 code freeze. Thus, we will hold this PR for now.

Understood, thanks for the notice!