-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WCOSS2/Acorn update DT_ATMOS to 120 for run completion using "faster" compile, also re-enable 3 hafs tests for WCOSS2. #1907
WCOSS2/Acorn update DT_ATMOS to 120 for run completion using "faster" compile, also re-enable 3 hafs tests for WCOSS2. #1907
Conversation
@BrianCurtis-NOAA I a little confused about how it was failing previously. Did it not run to completion because it is unstable at the longer timestep (the model blew up)? Or, did it run to completion but failed baseline comparison? |
It would fail at some point later in the model run time with a saturation vapor pressure issue. Instability |
@BrianCurtis-NOAA In the issue description you wrote "it is not able to run to completion and compare with its baselines". It never gets to comparing with a baseline if it fails during the run, right? |
Typo, should say "it is now able to run to completion and compare with its baselines" |
Hey @BrianCurtis-NOAA . I think we're ready to start here, if you can resolve conflicts. |
@zach1221 OK done. We don't need a new bl_date because i'm just adding "new" tests. |
Baselines copied over, onto comparisons for WCOSS/Acorn. |
Acorn slow, still 138 tasks. I'll check it later. |
On Hera, regional_atmaq_faster_intel failed most comparisons:
|
I am ok to update current baseline of regional_atmaq_faster_intel with new one across RDHPCS. @BrianCurtis-NOAA what do you think? |
Jenkins-ci ORTs failed |
Yes, the test will have new baselines across the board. |
Jenkins-ci ORTs failed |
Platform team is running tests on the jenkins-ci issue, so there may be some failure notifications. |
Jenkins-ci ORTs failed |
All tests are done. We can merge this pr. @FernandoAndrade-NOAA thanks for pushing hera log. |
Jenkins-ci ORTs passed |
PR Author Checklist:
Description
The test "regional_atmaq_faster" would not run to completion on WCOSS2/Acorn with an instability from the saturation vapor pressure late in the model run time, but by changing the DT_ATMOS to 120, it is now able to run to completion and compare with its baselines successfully.
This PR also enabled three tests on WCOSS2 for hafs that were disabled previously.
Linked Issues and Pull Requests
Associated UFSWM Issue to close
Closes #1742
Closes #1896
Subcomponent Pull Requests
N/A
Blocking Dependencies
None
Subcomponents involved:
Anticipated Changes
Input data
Regression Tests:
Tests effected by changes in this PR:
regional_atmaq_faster will be added on both Acorn and WCOSS2 bring back baselines for: - hafs_regional_docn - hafs_regional_docs_oisst - hafs_regional_datm_cdepsLibraries
Code Managers Log
Testing Log: