Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in changes from production/AQM.v7 #1656

Merged
merged 15 commits into from
Mar 21, 2023

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Mar 15, 2023

Description

This PR bring in changes from the production/AQM.v7 branch enabling debug mode to be run in the ATMAQ application.

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

regional_atmaq, regional_atmaq_debug, regional_atmaq_faster

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@BrianCurtis-NOAA
Copy link
Collaborator Author

RegressionTests_hera.gnu.log
RegressionTests_hera.intel.log

Only the atmaq tests will need new baselines

@BrianCurtis-NOAA BrianCurtis-NOAA added the Baseline Updates Current baselines will be updated. label Mar 16, 2023
@BrianCurtis-NOAA BrianCurtis-NOAA self-assigned this Mar 16, 2023
@github-actions
Copy link

@BrianCurtis-NOAA please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • fv3 NOT up to date

@BrianCurtis-NOAA BrianCurtis-NOAA added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Mar 17, 2023
@jkbk2004
Copy link
Collaborator

@BrianCurtis-NOAA We don't need to rush for other PRs. Also this PR is ready. We can start working on this PR. Can you put new BL_DATE=20230320 ? Then I will go ahead to copy over baselines on RDHPCs and create new aqm baselines.

@zach1221 zach1221 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Mar 20, 2023
@zach1221
Copy link
Collaborator

Jenkins-ci logs attached. ORTs passed.
ufs-weather-model » ort-docker-pipeline » PR-1656 #1 Console [Jenkins].pdf

@jkbk2004
Copy link
Collaborator

Gaea queue wasn't moving yesterday. Gaea system admin is currently working on lustre file system. We will skip Gaea for this pr.

@BrianCurtis-NOAA
Copy link
Collaborator Author

Gaea queue wasn't moving yesterday. Gaea system admin is currently working on lustre file system. We will skip Gaea for this pr.

Want to start merge?

@jkbk2004
Copy link
Collaborator

Sure! We can start merging process.

@BrianCurtis-NOAA
Copy link
Collaborator Author

@jkbk2004 Ready for reviews/merge.

@jkbk2004 jkbk2004 added the Waiting for Reviews The PR is waiting for reviews from associated component PR's. label Mar 21, 2023
@jkbk2004 jkbk2004 merged commit 10ceadd into ufs-community:develop Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. jenkins-ci Jenkins CI: ORT build/test on docker container Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

enable debug mode in regional AQM
6 participants