Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is EMC flake model #164

Merged
merged 14 commits into from
Jul 21, 2020
Merged

This is EMC flake model #164

merged 14 commits into from
Jul 21, 2020

Conversation

YihuaWu-NOAA
Copy link
Contributor

@YihuaWu-NOAA YihuaWu-NOAA commented Jul 10, 2020

Updated NCAR ccpp physics
Added flake

Associated PRs:

NCAR/ccpp-physics#471
NOAA-EMC/fv3atm#141
#164

@@ -0,0 +1,338 @@
&amip_interp_nml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this parm file be joined with the existing GFS v16 beta parm file, using variable substitutions?


cp ${PATHRT}/../FV3/ccpp/suites/suite_${CCPP_SUITE}.xml suite_${CCPP_SUITE}.xml

# Add path to libccpp.so and libccpphys.so to LD_LIBRARY_PATH, append to module-setup.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block (lines 24-28) is no longer needed, please remove.

@@ -0,0 +1,28 @@
rm -fr INPUT RESTART
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this regression test setup-run-dir script be joined with an existing script, using variables to control copying the ORO_FLAKE data?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to have this new feature separate from gfs_v16 as the feature does not belong to gfs_v16, but based on gfs_v16. In the future it can be one of candidate to be included in next production branch, srw, RRFS, or gfsv17.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, all good.

tests/rt.conf Outdated
@@ -166,3 +166,7 @@ COMPILE | CCPP=Y SUITES=FV3_GFS_2017_gfdlmp,FV3_GFS_2017_gfdlmp_noahmp
COMPILE | CCPP=Y SUITES=FV3_GFS_2017_gfdlmp,FV3_GFS_2017_gfdlmp_noahmp | standard | jet.intel | fv3 |

RUN | fv3_ccpp_gocart_clm | standard | | fv3 |
######################################################################################################################################################################################
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to combine this COMPILE line with a previous one (for example where the original GFSv16beta suite is compiled) to avoid an extra compile step?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add this regression test to rt_gnu.conf as well. @junwang-noaa @DusanJovic-NOAA

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I did it

@YihuaWu-NOAA
Copy link
Contributor Author

YihuaWu-NOAA commented Jul 16, 2020 via email

@climbfuji
Copy link
Collaborator

climbfuji commented Jul 16, 2020 via email

@YihuaWu-NOAA
Copy link
Contributor Author

YihuaWu-NOAA commented Jul 16, 2020 via email

@YihuaWu-NOAA
Copy link
Contributor Author

YihuaWu-NOAA commented Jul 17, 2020 via email

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Jul 17, 2020 via email

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submodule pointer update is still missing. I see fv3atm's hash as cdbe98a, but it should be 9e5074e.

@@ -0,0 +1,28 @@
rm -fr INPUT RESTART
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, all good.

@climbfuji climbfuji self-requested a review July 20, 2020 20:57
@junwang-noaa junwang-noaa merged commit 15124ee into ufs-community:develop Jul 21, 2020
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model.p7b that referenced this pull request Jul 20, 2021
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
Modified diag_table* to include stochastic block. Updated stochastic …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants