Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in calculations for point source emissions in AQM #1560

Merged
merged 30 commits into from
Jan 9, 2023

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Jan 6, 2023

Description

This PR brings in a capability to the AQM to add point source emissions to air quality calculations.

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Test regional_atmaq 152 failed in check_result failed
Test regional_atmaq_debug 153 failed in check_result failed

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Depends on NOAA-EMC/fv3atm#616
Depends on NOAA-EMC/AQM#53

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@BrianCurtis-NOAA BrianCurtis-NOAA added Baseline Updates Current baselines will be updated. input data change Input data change New Input Data Req'd This PR requires new data to be sync across platforms and removed input data change Input data change labels Jan 6, 2023
@BrianCurtis-NOAA BrianCurtis-NOAA marked this pull request as ready for review January 6, 2023 16:03
@BrianCurtis-NOAA
Copy link
Collaborator Author

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: BL
[BL] Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/1188307026/20230107004518/ufs-weather-model
[BL] Error: Test control_c384 018 failed in run_test failed
Please make changes and add the following label back: jet-intel-BL

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jan 9, 2023

All tests are done. we can start merging process. can we get final review/

@jkbk2004 jkbk2004 self-requested a review January 9, 2023 21:05
@jkbk2004 jkbk2004 merged commit e50f701 into ufs-community:develop Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. New Input Data Req'd This PR requires new data to be sync across platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants