Aqm bugfixes + New AQM Debug RT (#1505), INLINE_POST default (#1503), WCOSS2 MAPL Enable Tests (#1507) #1505

BrianCurtis-NOAA · 2022-11-29T20:09:45Z

PR Checklist

This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

This PR brings in a new regression test (regional_atmaq_debug) to make sure that AQM changes don't break the ability for ATMAQ app to run in Debug mode.

Issue(s) addressed

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

Dependencies

waiting on Small Fengsha updates, Updated AQM Logging, Fixes for UFSWM Debug Model Run NOAA-EMC/AQM#43

…r-model into aqm_bugfixes

…uoro

…uoro small updates to AQM

…r-model into aqm_bugfixes

…ed runs

BrianCurtis-NOAA · 2022-11-30T16:56:14Z

ORT Results

baseline dir = /scratch1/NCEPDEV/stmp4/Brian.Curtis/FV3_OPNREQ_TEST/OPNREQ_TEST/regional_atmaq_debug_bit_base
working dir  = /scratch1/NCEPDEV/stmp2/Brian.Curtis/FV3_OPNREQ_TEST/opnReqTest_23636/regional_atmaq_debug_bit_base
Checking test bit_base regional_atmaq_debug results ....
Moving baseline bit_base regional_atmaq_debug files ....
 Moving sfcf000.nc .........OK
 Moving sfcf001.nc .........OK
 Moving atmf000.nc .........OK
 Moving atmf001.nc .........OK
 Moving RESTART/coupler.res .........OK
 Moving RESTART/fv_core.res.nc .........OK
 Moving RESTART/fv_core.res.tile1.nc .........OK
 Moving RESTART/fv_srf_wnd.res.tile1.nc .........OK
 Moving RESTART/fv_tracer.res.tile1.nc .........OK
 Moving RESTART/phy_data.nc .........OK
 Moving RESTART/sfc_data.nc .........OK

  0: The total amount of wall time                        = 1212.429568
  0: The maximum resident set size (KB)                   = 1055764

Test bit_base regional_atmaq_debug PASS

baseline dir = /scratch1/NCEPDEV/stmp4/Brian.Curtis/FV3_OPNREQ_TEST/OPNREQ_TEST/regional_atmaq_debug_std_base
working dir  = /scratch1/NCEPDEV/stmp2/Brian.Curtis/FV3_OPNREQ_TEST/opnReqTest_23636/regional_atmaq_debug_std_base
Checking test std_base regional_atmaq_debug results ....
Moving baseline std_base regional_atmaq_debug files ....
 Moving sfcf000.nc .........OK
 Moving sfcf001.nc .........OK
 Moving atmf000.nc .........OK
 Moving atmf001.nc .........OK
 Moving RESTART/coupler.res .........OK
 Moving RESTART/fv_core.res.nc .........OK
 Moving RESTART/fv_core.res.tile1.nc .........OK
 Moving RESTART/fv_srf_wnd.res.tile1.nc .........OK
 Moving RESTART/fv_tracer.res.tile1.nc .........OK
 Moving RESTART/phy_data.nc .........OK
 Moving RESTART/sfc_data.nc .........OK

  0: The total amount of wall time                        = 1271.699074
  0: The maximum resident set size (KB)                   = 1200060

Test std_base regional_atmaq_debug PASS


baseline dir = /scratch1/NCEPDEV/stmp4/Brian.Curtis/FV3_OPNREQ_TEST/OPNREQ_TEST/regional_atmaq_debug_std_base
working dir  = /scratch1/NCEPDEV/stmp2/Brian.Curtis/FV3_OPNREQ_TEST/opnReqTest_23636/regional_atmaq_debug_thr
Checking test thr regional_atmaq_debug results ....
 Comparing sfcf000.nc .........OK
 Comparing sfcf001.nc .........OK
 Comparing atmf000.nc .........OK
 Comparing atmf001.nc .........OK
 Comparing RESTART/coupler.res .........OK
 Comparing RESTART/fv_core.res.nc .........OK
 Comparing RESTART/fv_core.res.tile1.nc .........OK
 Comparing RESTART/fv_srf_wnd.res.tile1.nc .........OK
 Comparing RESTART/fv_tracer.res.tile1.nc .........OK
 Comparing RESTART/phy_data.nc .........OK
 Comparing RESTART/sfc_data.nc .........OK

  0: The total amount of wall time                        = 1068.725104
  0: The maximum resident set size (KB)                   = 1197900

Test thr regional_atmaq_debug PASS

…into aqm_bugfixes

jkbk2004 · 2022-11-30T18:37:37Z

@BrianCurtis-NOAA sounds like all sets. I am adding bl labels from hera.

BrianCurtis-NOAA · 2022-11-30T19:02:55Z

@jkbk2004 only need to run regional_atmaq and regional_atmaq_debug creation i believe. The others should not change. Might be easiest to do that manually, and run the AutoRT afterwards.

jkbk2004 · 2022-11-30T19:13:09Z

@jkbk2004 only need to run regional_atmaq and regional_atmaq_debug creation i believe. The others should not change. Might be easiest to do that manually, and run the AutoRT afterwards.

sure!

on-behalf-of @ufs-community <[email protected]>

BrianCurtis-NOAA · 2022-12-01T01:40:00Z

Automated RT Failure Notification
Machine: hera
Compiler: gnu
Job: RT
[RT] Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/1139478807/20221130234511/ufs-weather-model
[RT] Error: Test cpld_control_p8 049 failed in run_test failed
[RT] Error: Test cpld_debug_p8 051 failed in run_test failed
Please make changes and add the following label back: hera-gnu-RT

on-behalf-of @ufs-community <[email protected]>

BrianCurtis-NOAA · 2022-12-01T04:50:50Z

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: RT
[RT] Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/1139478807/20221130233017/ufs-weather-model
[RT] Error: Test hafs_regional_atm_thompson_gfdlsf 118 failed in run_test failed
[RT] Error: Test hafs_regional_atm_wav 120 failed in run_test failed
[RT] Error: Test hafs_regional_atm_ocn_wav 121 failed in run_test failed
[RT] Error: Test hafs_regional_docn 122 failed in run_test failed
[RT] Error: Test hafs_regional_datm_cdeps 124 failed in run_test failed
[RT] Error: Test regional_atmaq 146 failed in run_test failed
[RT] Error: Test regional_atmaq_debug 147 failed in run_test failed
Please make changes and add the following label back: jet-intel-RT

jkbk2004 · 2022-12-01T16:21:50Z

With turning off regional_atmaq_debug on jet, we are good to start merging process.

DusanJovic-NOAA and others added 8 commits November 22, 2022 20:22

Inline post is now compiled by default on all supported platforms

a581261

update .gitmodules and AQM hash

b02ef99

Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…

db881af

…r-model into aqm_bugfixes

Create Debug RT for AQM, Bring in fixes from debug testing and @rmont…

65559bb

…uoro small updates to AQM

Merge branch 'ufs-community:develop' into aqm_bugfixes

915954d

Update AQM hash

1261f32

Merge branch 'aqm_bugfixes' of github.com:BrianCurtis-NOAA/ufs-weathe…

37c720a

…r-model into aqm_bugfixes

update wcoss2 module files with esmf/mapl and turn on gocart in coupl…

f415478

…ed runs

BrianCurtis-NOAA marked this pull request as ready for review November 30, 2022 15:26

BrianCurtis-NOAA changed the title ~~Aqm bugfixes~~ Aqm bugfixes + New AQM Debug RT Nov 30, 2022

BrianCurtis-NOAA added 4 commits November 30, 2022 17:16

Update AQM Hash

a823a7b

Merge remote-tracking branch 'DusanJovic-NOAA/inlinepost_default_on' …

85b33c9

…into aqm_bugfixes

Merge remote-tracking branch 'junwang-noaa/wcoss2mapl' into aqm_bugfixes

7076767

BLDATE to 20221130

73b6e2e

BrianCurtis-NOAA changed the title ~~Aqm bugfixes + New AQM Debug RT~~ Aqm bugfixes + New AQM Debug RT (#1505), INLINE_POST default (#1503), WCOSS2 MAPL Enable Tests (#1507) Nov 30, 2022

jkbk2004 added the Baseline Updates Current baselines will be updated. label Nov 30, 2022

WCOSS2 Intel RT Log

d2fbc99

jkbk2004 added hera-intel-RT labels Nov 30, 2022

BrianCurtis-NOAA removed gaea-intel-RT labels Nov 30, 2022

BrianCurtis-NOAA removed the hera-gnu-RT label Nov 30, 2022

BrianCurtis-NOAA added 2 commits November 30, 2022 18:51

[AutoRT] orion.intel Job Completed.

939ad72

on-behalf-of @ufs-community <[email protected]>

[AutoRT] hera.intel Job Completed.

100f5bf

on-behalf-of @ufs-community <[email protected]>

[AutoRT] gaea.intel Job Completed.

73a6772

on-behalf-of @ufs-community <[email protected]>

jkbk2004 and others added 4 commits December 1, 2022 06:12

add cheyenne intel/gnu RT logs: passed

e6cf9b0

add hera.gnu RT log: passed

b36ec70

jet RT passes except regional_atmaq_debug: timeout issue

a2802d1

disable regional_atmaq_debug on jet: time out issue

99e6784

jkbk2004 requested review from DusanJovic-NOAA, ChunxiZhang-NOAA and jkbk2004 December 1, 2022 16:17

ChunxiZhang-NOAA approved these changes Dec 1, 2022

View reviewed changes

jkbk2004 mentioned this pull request Dec 1, 2022

Small Fengsha updates, Updated AQM Logging, Fixes for UFSWM Debug Model Run NOAA-EMC/AQM#43

Merged

1 task

DusanJovic-NOAA approved these changes Dec 1, 2022

View reviewed changes

jkbk2004 mentioned this pull request Dec 1, 2022

Update Regression Test to include gfsv17 prototypes that are after prototype 8, and turn on prognostic closure. #1480

Merged

15 tasks

BrianCurtis-NOAA added 2 commits December 1, 2022 19:58

Revert .gitmodules and update AQM Hash

7bc38f5

Actually add .gitmodules changes

3ca5f25

jkbk2004 merged commit 7a1ce44 into ufs-community:develop Dec 1, 2022

grantfirl mentioned this pull request Dec 20, 2022

UFS-dev PR#27 NCAR/ufs-weather-model#81

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Aqm bugfixes + New AQM Debug RT (#1505), INLINE_POST default (#1503), WCOSS2 MAPL Enable Tests (#1507) #1505

Aqm bugfixes + New AQM Debug RT (#1505), INLINE_POST default (#1503), WCOSS2 MAPL Enable Tests (#1507) #1505

BrianCurtis-NOAA commented Nov 29, 2022 •

edited by jkbk2004

Loading

BrianCurtis-NOAA commented Nov 30, 2022

jkbk2004 commented Nov 30, 2022

BrianCurtis-NOAA commented Nov 30, 2022

jkbk2004 commented Nov 30, 2022

BrianCurtis-NOAA commented Dec 1, 2022

BrianCurtis-NOAA commented Dec 1, 2022

jkbk2004 commented Dec 1, 2022

Aqm bugfixes + New AQM Debug RT (#1505), INLINE_POST default (#1503), WCOSS2 MAPL Enable Tests (#1507) #1505

Aqm bugfixes + New AQM Debug RT (#1505), INLINE_POST default (#1503), WCOSS2 MAPL Enable Tests (#1507) #1505

Conversation

BrianCurtis-NOAA commented Nov 29, 2022 • edited by jkbk2004 Loading

PR Checklist

Description

Issue(s) addressed

Testing

Dependencies

BrianCurtis-NOAA commented Nov 30, 2022

jkbk2004 commented Nov 30, 2022

BrianCurtis-NOAA commented Nov 30, 2022

jkbk2004 commented Nov 30, 2022

BrianCurtis-NOAA commented Dec 1, 2022

BrianCurtis-NOAA commented Dec 1, 2022

jkbk2004 commented Dec 1, 2022

BrianCurtis-NOAA commented Nov 29, 2022 •

edited by jkbk2004

Loading