Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AQM] Implement output capabilities for production and bring pm25 as a 3D diagnostic tracer in UFSWM #1494

Merged
merged 27 commits into from
Nov 18, 2022

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Nov 16, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

Description

Bring output capabilities from AQM for PM2.5 and use PM2.5 as 3D tracer in UFSWM

Tested on Hera/Orion, needs new baseline for JUST regional_atmaq test.

Issue(s) addressed

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

@zach1221 zach1221 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Nov 17, 2022
@BrianCurtis-NOAA
Copy link
Collaborator Author

Automated RT Failure Notification
Machine: hera
Compiler: gnu
Job: RT
[RT] Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/1125089145/20221117230017/ufs-weather-model
[RT] Error: Test cpld_control_p8 049 failed in run_test failed
Please make changes and add the following label back: hera-gnu-RT

@jkbk2004
Copy link
Collaborator

@BrianCurtis-NOAA all RT tests are done. we can start merging process.

@jkbk2004 jkbk2004 merged commit d31ee42 into ufs-community:develop Nov 18, 2022
@BrianCurtis-NOAA
Copy link
Collaborator Author

Automated RT Failure Notification
Machine: orion
Compiler: intel
Job: RT
[RT] Repo location: /work/noaa/nems/emc.nemspara/autort/pr/1125089145/20221117144518/ufs-weather-model
Please make changes and add the following label back: orion-intel-RT

Copy link
Collaborator

@rmontuoro rmontuoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AQM configuration for the regional_atmaq regression test needs to be updated as per provided comment.

@@ -29,7 +29,7 @@ ctm_pmdiag: true
#
# Input emissions
#
emission_sources: anthro fire
emission_sources: anthro fire prod
Copy link
Collaborator

@rmontuoro rmontuoro Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fengsha needs to be added to the emission sources:

emission_sources: anthro fire fengsha prod

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fengsha is currently breaking the RT, but I know there are fixes coming in immediately. This can be addressed with that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. jenkins-ci Jenkins CI: ORT build/test on docker container
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing operational products
4 participants