Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AQM] [FV3] [WW3] Enable CMAQ scavenging and wet removal in resolved clouds, ESMF 8.4 support for AQM, Update WW3. #1456

Merged

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Oct 14, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

This PR enables CMAQ-provided simplistic scavenging and wet removal in resolved clouds

Issue(s) addressed

Fixes NOAA-EMC/AQM/issues/23
Fixes #1473
Fixes NOAA-EMC/AQM/issues/5

Additional PR's closed (merged)

Closes: #1474 (WW3 update)
Closes: #1476 (AQM ESMF 8.4 support))

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

Depends on: NOAA-EMC/AQM/pull/24
Depends on: NOAA-EMC/fv3atm/pull/593
Depends on: NOAA-EMC/WW3/pull/840

@BrianCurtis-NOAA
Copy link
Collaborator Author

Baselines are changing and it's expected, but only for regional_atmaq

baseline dir = /scratch1/NCEPDEV/nems/emc.nemspara/RT/NEMSfv3gfs/develop-20221007/INTEL/regional_atmaq
working dir  = /scratch1/NCEPDEV/stmp2/Brian.Curtis/FV3_RT/rt_11339/regional_atmaq
Checking test 001 regional_atmaq results ....
 Comparing sfcf000.nc ............ALT CHECK......NOT OK
 Comparing sfcf003.nc ............ALT CHECK......NOT OK
 Comparing sfcf006.nc ............ALT CHECK......NOT OK
 Comparing atmf000.nc ............ALT CHECK......NOT OK
 Comparing atmf003.nc ............ALT CHECK......NOT OK
 Comparing atmf006.nc ............ALT CHECK......NOT OK
 Comparing RESTART/coupler.res .........OK
 Comparing RESTART/fv_core.res.nc .........OK
 Comparing RESTART/fv_core.res.tile1.nc .........OK
 Comparing RESTART/fv_srf_wnd.res.tile1.nc .........OK
 Comparing RESTART/fv_tracer.res.tile1.nc ............ALT CHECK......NOT OK
 Comparing RESTART/phy_data.nc .........OK
 Comparing RESTART/sfc_data.nc .........OK

@BrianCurtis-NOAA
Copy link
Collaborator Author

Hera.intel for atmaq testing for reproducability with new baseline:

baseline dir = /scratch1/NCEPDEV/stmp4/Brian.Curtis/FV3_RT/REGRESSION_TEST_INTEL/regional_atmaq
working dir  = /scratch1/NCEPDEV/stmp2/Brian.Curtis/FV3_RT/rt_17561/regional_atmaq
Checking test 001 regional_atmaq results ....
 Comparing sfcf000.nc .........OK
 Comparing sfcf003.nc .........OK
 Comparing sfcf006.nc .........OK
 Comparing atmf000.nc .........OK
 Comparing atmf003.nc .........OK
 Comparing atmf006.nc .........OK
 Comparing RESTART/coupler.res .........OK
 Comparing RESTART/fv_core.res.nc .........OK
 Comparing RESTART/fv_core.res.tile1.nc .........OK
 Comparing RESTART/fv_srf_wnd.res.tile1.nc .........OK
 Comparing RESTART/fv_tracer.res.tile1.nc .........OK
 Comparing RESTART/phy_data.nc .........OK
 Comparing RESTART/sfc_data.nc .........OK
Test 001 regional_atmaq PASS

@zach1221 zach1221 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Oct 21, 2022
@zach1221
Copy link
Collaborator

@BrianCurtis-NOAA
Copy link
Collaborator Author

Automated RT Failure Notification
Machine: orion
Compiler: intel
Job: RT
[RT] Repo location: /work/noaa/nems/emc.nemspara/autort/pr/1087776613/20221021101509/ufs-weather-model
[RT] Error: Test control_c384gdas 034 failed in run_test failed
[RT] Error: Test hafs_regional_storm_following_1nest_atm_ocn_wav 134 failed in run_test failed
[RT] Error: Test hafs_regional_docn 136 failed in run_test failed
Please make changes and add the following label back: orion-intel-RT

@BrianCurtis-NOAA
Copy link
Collaborator Author

Ignore the Acorn log for now. Pushed the module updates for acorn based on discussion in code managers channel.

@BrianCurtis-NOAA
Copy link
Collaborator Author

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: RT
[RT] Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/1087776613/20221102163020/ufs-weather-model
[RT] Error: Test regional_atmaq 147 failed in check_result failed
[RT] Error: Test regional_atmaq 147 failed in run_test failed
Please make changes and add the following label back: jet-intel-RT

@BrianCurtis-NOAA
Copy link
Collaborator Author

@jkbk2004 lets merge in the AM, any update on Orion?

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 3, 2022

@jkbk2004 lets merge in the AM, any update on Orion?

@BrianCurtis-NOAA Orion is back now. No problem to merge first thing tomorrow morning.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 3, 2022

@BrianCurtis-NOAA I am moving to fv3atm pr 593 to ask merge there.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 3, 2022

@BrianCurtis-NOAA I am moving to fv3atm pr 593 to ask merge there.

@BrianCurtis-NOAA the fv3atm pr was merged. With the hash update, we can merge in this pr,

@jkbk2004 jkbk2004 merged commit 5db3fac into ufs-community:develop Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated.
Projects
None yet
6 participants