Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake build system for AQM #1445

Merged
merged 12 commits into from
Oct 7, 2022

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Oct 3, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

AQM Currently fails debug builds and has an issue with building serially and module_mod. The changes in this PR address the below issues in AQM

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
NOAA-EMC/AQM#10
NOAA-EMC/AQM#14

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@BrianCurtis-NOAA BrianCurtis-NOAA changed the title .gitmodules updates and hash to rmontuoro/bugfix/aqm-build-system for… Update CMake build system for AQM Oct 3, 2022
@BrianCurtis-NOAA
Copy link
Collaborator Author

Ran regional_atmaq on hera.intel and no changes to baselines.

baseline dir = /scratch1/NCEPDEV/nems/emc.nemspara/RT/NEMSfv3gfs/develop-20220929/INTEL/regional_atmaq
working dir  = /scratch1/NCEPDEV/stmp2/Brian.Curtis/FV3_RT/rt_22168/regional_atmaq
Checking test 001 regional_atmaq results ....
 Comparing sfcf000.nc .........OK
 Comparing sfcf003.nc .........OK
 Comparing sfcf006.nc .........OK
 Comparing atmf000.nc .........OK
 Comparing atmf003.nc .........OK
 Comparing atmf006.nc .........OK
 Comparing RESTART/coupler.res .........OK
 Comparing RESTART/fv_core.res.nc .........OK
 Comparing RESTART/fv_core.res.tile1.nc .........OK
 Comparing RESTART/fv_srf_wnd.res.tile1.nc .........OK
 Comparing RESTART/fv_tracer.res.tile1.nc .........OK
 Comparing RESTART/phy_data.nc .........OK
 Comparing RESTART/sfc_data.nc .........OK
Test 001 regional_atmaq PASS

@BrianCurtis-NOAA BrianCurtis-NOAA added the No Baseline Change No Baseline Change label Oct 3, 2022
@BrianCurtis-NOAA BrianCurtis-NOAA marked this pull request as ready for review October 3, 2022 19:59
@github-actions
Copy link

github-actions bot commented Oct 5, 2022

@BrianCurtis-NOAA please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date

@jkbk2004 jkbk2004 added gaea-intel-RT jenkins-ci Jenkins CI: ORT build/test on docker container labels Oct 5, 2022
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Oct 6, 2022

@BrianCurtis-NOAA it turns out git version issue on jenkins-ci side. I am running on a sandbox jenkins pipeline. it is running ok but slow as the sandbox was set up as sequential. We are ok to move on to merge the PR.

@BrianCurtis-NOAA
Copy link
Collaborator Author

NOAA-EMC/AQM/pull/15 is merged. Ready for merge here.

@junwang-noaa
Copy link
Collaborator

@jkbk2004 Does Jenkins-CI run OK? Can users see the run log file?

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Oct 6, 2022

@BrianCurtis-NOAA Zach is monitoring the Jenkins-ci run with fix now. Let's merge in jenkins-ci log first thing tomorrow. I like to force to have jenkins-ci log.

@zach1221
Copy link
Collaborator

zach1221 commented Oct 7, 2022

Run log below from Jenkins. Please let me know if anything else is needed.
ufs-weather-model » ort-docker-wrapper-pipeline » PR-1445 #3 Console [Jenkins].pdf

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Oct 7, 2022

Run log below from Jenkins. Please let me know if anything else is needed. ufs-weather-model » ort-docker-wrapper-pipeline » PR-1445 #3 Console [Jenkins].pdf

@zach1221 We need to resolve the public accessibility issue of full jenkins-ci log outputs in the PR. Please, continue to follow up with Jenkins team.

@jkbk2004 jkbk2004 merged commit ea0b6e4 into ufs-community:develop Oct 7, 2022
@zach1221 zach1221 removed the jenkins-ci Jenkins CI: ORT build/test on docker container label Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants