Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Fengsha dust emission scheme and upgrading PIO to 2.5.7 and switch three HPC's to epic's HPC Stack #1405

Merged
merged 14 commits into from
Sep 16, 2022

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Sep 7, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

This PR add the fengsha windblown dust emission model to AQM.

Issue(s) addressed

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

@jkbk2004 jkbk2004 mentioned this pull request Sep 14, 2022
16 tasks
@BrianCurtis-NOAA BrianCurtis-NOAA added the No Baseline Change No Baseline Change label Sep 14, 2022
@BrianCurtis-NOAA
Copy link
Collaborator Author

@jkbk2004 PIO 2.5.7 changes made, and new stack locations for Orion, Gaea, Jet all setup.

@jkbk2004
Copy link
Collaborator

@jkbk2004 PIO 2.5.7 changes made, and new stack locations for Orion, Gaea, Jet all setup.

Sure! I will start testing.

@BrianCurtis-NOAA
Copy link
Collaborator Author

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: RT
[RT] Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/1049127526/20220914170012/ufs-weather-model
Please make changes and add the following label back: jet-intel-RT

@BrianCurtis-NOAA
Copy link
Collaborator Author

Automated RT Failure Notification
Machine: orion
Compiler: intel
Job: RT
[RT] Repo location: /work/noaa/nems/emc.nemspara/autort/pr/1049127526/20220914120010/ufs-weather-model
Please make changes and add the following label back: orion-intel-RT

@BrianCurtis-NOAA
Copy link
Collaborator Author

@jkbk2004 Jet: Seems like an ecflow issue, probably should retry:
Orion:

Lmod has detected the following error: The following module(s) are unknown:
"esmf/8.3.0b09" "jasper/2.0.25"

Something's wrong with your stack..

@jkbk2004
Copy link
Collaborator

/work/noaa/nems/emc.nemspara/autort/pr/1049127526/20220914120010/ufs-weather-model
Manual builds ok on orion. I think it is permission issue to epic-ps. I did chmod -R 2775. it is running ok on gaea. I will re-submit on jet/orion.

@BrianCurtis-NOAA
Copy link
Collaborator Author

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: RT
[RT] Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/1049127526/20220914174517/ufs-weather-model
Please make changes and add the following label back: jet-intel-RT

@jkbk2004
Copy link
Collaborator

@BrianCurtis-NOAA good to see auto-rt build pr ok now on orion. I will let it run thru.

@jkbk2004
Copy link
Collaborator

@BrianCurtis-NOAA As all tests are done, we can go ahead to merge. No problem to follow up after you get back. but if you like, go ahead to merge in AQM dependency and update submodule pointer and revert gitmodules branch on this PR.

@BrianCurtis-NOAA BrianCurtis-NOAA changed the title Adding Fengsha dust emission scheme Adding Fengsha dust emission scheme and upgrading PIO to 2.5.7 Sep 16, 2022
@BrianCurtis-NOAA BrianCurtis-NOAA changed the title Adding Fengsha dust emission scheme and upgrading PIO to 2.5.7 Adding Fengsha dust emission scheme and upgrading PIO to 2.5.7 and switch three HPC's to epic's HPC Stack Sep 16, 2022
@BrianCurtis-NOAA
Copy link
Collaborator Author

@jkbk2004 All set to go. I cannot approve my own PR's code changes, so please get reviewers and merge! Thanks!

@jkbk2004 jkbk2004 merged commit df5da59 into ufs-community:develop Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Fengsha2 dust emissions scheme into AQM
3 participants