Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of jet config and GNU regression tests #140

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jun 2, 2020

Changes in this PR:

  • tests/rt_gnu.conf: turn off IPD tests, no longer working on Cheyenne with GNU compiler (segmentation fault)
  • update of jet modulefile and correction of cmake name from jet to jet.intel (to match gnumake)

No need to run regression tests on any of the platforms, since the changes are confined to files that are not used in any of these tests.

Todo in future PRs:

  • re-enable regression testing on jet.intel, possibly update NCEPlibs installation
  • clean up various rt*.conf regression test configs

…e with GNU compiler (segmentation fault)

- update of jet modulefile and correction of cmake name from jet to jet.intel (to match gnumake)
@climbfuji
Copy link
Collaborator Author

Testing on Cheyenne with both Intel and GNU:

  • create new baselines using rt.sh -l rt_stampede_cheyenne.conf -c -e (for Intel) or rt.sh -l rt_gnu.conf -c -e (for GNU)
  • rsync NEW_BASELINE directories to RTPWD
  • verify against baselines using rt.sh -l rt_stampede_cheyenne.conf -e (for Intel) or rt.sh -l rt_gnu.conf -e (for GNU)

All tests pass.

rt_cheyenne_intel_create.log
rt_cheyenne_intel_verify.log
rt_cheyenne_gnu_create.log
rt_cheyenne_gnu_verify.log

@climbfuji
Copy link
Collaborator Author

Testing on Jet with Intel: I successfully compiled the code using the following two commands (all CCPP suites):

cmake (PROD mode)

./compile_cmake.sh $PWD/.. jet.intel 'CCPP=Y' '' NO NO 2>&1 | tee compile.log

gnumake (DEBUG mode)

 ./compile.sh $PWD/../FV3 jet.intel 'CCPP=Y DEBUG=Y' '' NO NO 2>&1 | tee compile.log

@climbfuji climbfuji marked this pull request as ready for review June 2, 2020 15:23
@@ -20,7 +20,7 @@ module load impi/2018.4.274
module load hdf5/1.10.4
module load netcdf/4.6.1

module use -a /lfs3/projects/hfv3gfs/GMTB/modulefiles/intel-18.0.5.274
module use -a /lfs4/HFIP/hfv3gfs/software/modulefiles/intel-18.0.5.274/impi-2018.4.274

##
### NCEP libraries (download and build manually for the time being; https://github.com/NCAR/NCEPlibs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since NCEPlibs team is rebuilding nceplibs, I expect we will change the nceplibs modules files later?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as noted above in the description of the PR. For now, the SAR real-time parallels can proceed with this version (same as they used until now).

@DusanJovic-NOAA DusanJovic-NOAA merged commit a0c27d8 into ufs-community:develop Jun 2, 2020
XiaSun-Atmos pushed a commit to XiaSun-Atmos/ufs-weather-model that referenced this pull request Aug 8, 2020
This PR contains cleanup work to address wrong units and some issues raised in recently merged PRs:
- correct units for latitude, longitude, and pi
- correct standard name air_temperature_save_from_cumulus_paramterization to air_temperature_save_from_convective_parameterization
- remove unused variables in two routines in `GFS_typedefs.F90`
- remove recently introduced variable `cycling` (part of GFS_control DDT), now a local variable in `physics/module_MYNNPBL_wrapper.F90`
- change order of interstitial schemes in `ccpp/suites/suite_FV3_GFS_2017_fv3wam.xml` to match other SDFs

Fixes ufs-community#138 and parts of ufs-community#137.
SamuelTrahanNOAA added a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Jun 13, 2022
* update submodule pointer for fv3atm

* Update baseline date

* hera.intel tests passed

* hera.gnu tests passed

* jet regression tests passed

* increase wallclock to 45 minutes on Jet due to threaded tests

Co-authored-by: samuel.trahan <[email protected]>
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
Clean up template namelist files for the forecast model (for various CCPP physics suites).
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
…l (hash 2f1c8e1) (#140)

## DESCRIPTION OF CHANGES: 
This PR (along with https://github.com/NOAA-EMC/regional_workflow/pull/492) update the UFS SRW App to work with a more up-to-date hash of the ufs-weather-model (2f1c8e1)

## TESTS CONDUCTED: 
Ran full suite of tests on Hera (aside from nco tests) with updated environment files (/scratch2/BMC/det/kavulich/workdir/update_app_master/step-by-step/expt_dirs/). The only new failures are only for older versions of NAM input; this is due to a change in the weather model, and will need to be handled in a separate PR.

Ran several end-to-end tests on Cheyenne (Intel 19.1.1) and Jet. Also ran the Graduate Student Test case on Orion. No failures outside of those outlined above and a few previously-known failures.

**Tests have not been run on WCOSS platforms; these will likely fail without being updated to the latest ESMF modules but DTC does not have access to update and test**

## ISSUE: 
Fixes issue #134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants