Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AQM Regression Test and documentation for AQM & Update upp submodule to fix in-line post issues for RRFS and HAFS #1298

Merged

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Jun 29, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • [] Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

A regression test using the newest AQM subcomponent was created.
Documentation for using AQM in UFSWM is also included.

Issue(s) addressed

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • opnReqTest for newly added/changed feature
  • [] CI (skipping)

Dependencies

NOAA-EMC/AQM/pull/4
NOAA-EMC/CMAQ/pull/1
NOAA-EMC/fv3atm/pull/558

Linked PR's

Closes #1286

DeniseWorthen and others added 30 commits April 26, 2021 15:58
@BrianCurtis-NOAA
Copy link
Collaborator Author

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: BL
[BL] Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/982694128/20220713194513/ufs-weather-model
Please make changes and add the following label back: jet-intel-BL

@BrianCurtis-NOAA
Copy link
Collaborator Author

Automated RT Failure Notification
Machine: gaea
Compiler: intel
Job: BL
[BL] Repo location: /lustre/f2/pdata/ncep/emc.nemspara/autort/pr/982694128/20220713183009/ufs-weather-model
[BL] Baseline creation and move successful
[RT] Repo location: /lustre/f2/pdata/ncep/emc.nemspara/autort/pr/982694128/20220713214030/ufs-weather-model
[RT] Error: Test compile_010 failed in run_compile failed
Please make changes and add the following label back: gaea-intel-BL

@BrianCurtis-NOAA
Copy link
Collaborator Author

BrianCurtis-NOAA commented Jul 14, 2022

ORT Passed in my previous PR: #1272 (comment)

@jkbk2004 jkbk2004 mentioned this pull request Jul 14, 2022
15 tasks
@jkbk2004
Copy link
Collaborator

@DusanJovic-NOAA @ChunxiZhang-NOAA @DeniseWorthen All tests are done. With final reviews, we can move on to merge the PR.

@jkbk2004
Copy link
Collaborator

@BrianCurtis-NOAA can we start merging process of the dependencies?

@jkbk2004
Copy link
Collaborator

@WenMeng-NOAA all tests are done. we can start merging in fv3atm pr558.

@junwang-noaa
Copy link
Collaborator

@BrianCurtis-NOAA Thanks for brining the AQM documentation!

@BrianCurtis-NOAA BrianCurtis-NOAA merged commit d3d2565 into ufs-community:develop Jul 15, 2022
@WenMeng-NOAA
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. New Input Data Req'd This PR requires new data to be sync across platforms
Projects
None yet
6 participants