-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AQM Regression Test and documentation for AQM & Update upp submodule to fix in-line post issues for RRFS and HAFS #1298
Add AQM Regression Test and documentation for AQM & Update upp submodule to fix in-line post issues for RRFS and HAFS #1298
Conversation
Automated RT Failure Notification |
on-behalf-of @ufs-community <[email protected]>
Automated RT Failure Notification |
ORT Passed in my previous PR: #1272 (comment) |
on-behalf-of @ufs-community <[email protected]>
@DusanJovic-NOAA @ChunxiZhang-NOAA @DeniseWorthen All tests are done. With final reviews, we can move on to merge the PR. |
@BrianCurtis-NOAA can we start merging process of the dependencies? |
@WenMeng-NOAA all tests are done. we can start merging in fv3atm pr558. |
@BrianCurtis-NOAA Thanks for brining the AQM documentation! |
Thanks! |
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
[] Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Description
A regression test using the newest AQM subcomponent was created.
Documentation for using AQM in UFSWM is also included.
Issue(s) addressed
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
NOAA-EMC/AQM/pull/4
NOAA-EMC/CMAQ/pull/1
NOAA-EMC/fv3atm/pull/558
Linked PR's
Closes #1286