[develop] Add analysis task.

[danielabdi-noaa]

DESCRIPTION OF CHANGES:

Add gsi analysis task from RRFS_dev1.
Note that there is no workflow so this PR can not be run independently until then.
However, it did successfully run for both spinup/production cycles in PR #540.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

TESTS CONDUCTED:

• hera.intel
  Run CONUS 3km test successfully in PR [develop] Incorporate RRFS_dev1 workflow to SRW and import most tasks #540
• orion.intel
• cheyenne.intel
• cheyenne.gnu
• gaea.intel
• jet.intel
• wcoss2.intel
• NOAA Cloud (indicate which platform)
• Jenkins
• fundamental test suite
• comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

• [develop] Add new RRFS variables such as NWGES and workflow control variables #647

DOCUMENTATION:

ISSUE:

• Add 3DEnVar analysis jobs/scripts/tasks #543

CHECKLIST

• My code follows the style guidelines in the Contributor's Guide
• I have performed a self-review of my own code using the Code Reviewer's Guide
• I have commented my code, particularly in hard-to-understand areas
• My changes need updates to the documentation. I have made corresponding changes to the documentation
• My changes do not require updates to the documentation (explain).
• My changes generate no new warnings
• New and existing tests pass with my changes
• Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

• Work In Progress
• bug
• enhancement
• documentation
• release
• high priority
• run_ci
• run_we2e_fundamental_tests
• run_we2e_comprehensive_tests
• Needs Cheyenne test
• Needs Jet test
• Needs Hera test
• Needs Orion test
• help wanted

CONTRIBUTORS (optional):

[MichaelLueken]

@danielabdi-noaa These changes look good to me!

In scripts/exregional_run_anal.sh, I have noted a commented line that looks like it can be safely removed, and left a comment regarding the copying the analysis results to INPUT for model forecast.

[JeffBeck-NOAA]

@danielabdi-noaa, can we change the j-job and ex-script names to something like *_run_analysis? Thanks!

[BenjaminBlake-NOAA]

@JeffBeck-NOAA @danielabdi-noaa If possible could we go with either analysis or analysis_gsi? We should remove the run_* prefix (see issue #633 ) Thanks!

[danielabdi-noaa]

@JeffBeck-NOAA @BenjaminBlake-NOAA Ok I will make it "analysis_gsi".

[panll]

It looks good to me!

[christinaholtNOAA]

In general the code looks good.

Please replace all instances of anal with either analysis or anl.

[christinaholtNOAA]

LGTM.

[BenjaminBlake-NOAA]

@danielabdi-noaa Thanks for addressing my comment to rename the task to analysis_gsi and for addressing Christina's suggestions. Everything looks good to me!

[MichaelLueken]

@danielabdi-noaa The nco_grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson_mynn_lam3km test failed on Cheyenne GNU, the grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16 test failed on Cheyenne Intel, the get_from_NOMADS_ics_FV3GFS_lbcs_FV3GFS test failed on Hera GNU, and the grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR test failed on Hera Intel. Finally, due to system issues on Orion, the automated testing failed to even initialize on the machine yesterday.

These are the tests that seem to constantly fail for those given platforms, so I have kicked off the Jenkins testing on Orion this morning (whatever was ailing Orion yesterday seems to be better now - the testing phase has already started), and once they complete, I will move forward with merging this work into develop.

[danielabdi-noaa]

@MichaelLueken Thanks for looking into the issues. Maybe we should remove these tests from the list at least until they become reliable enough to yield greens. I excluded some nco_* and get_HPSS tests from the original coverage list for this particular reason.

[MichaelLueken]

@MichaelLueken Thanks for looking into the issues. Maybe we should remove these tests from the list at least until they become reliable enough to yield greens. I excluded some nco_* and get_HPSS tests from the original coverage list for this particular reason.

@danielabdi-noaa This is a good idea.

Hopefully the two verification failures will be corrected by PR #683. The get_from_NOMADS test seems to fail depending on when the test is submitted (seems to have issues pulling the necessary ICs and LBCs from NOMADS). The nco_grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson_mynn_lam3km test is the one that isn't clear why it is failing. No useful information is added to the log, further complicating the issue.

[MichaelLueken]

@danielabdi-noaa All tests on Orion successfully passed. When the Jenkins tests were kicked off for Orion, it looks like it attempted to kick off Hera tests too, leading to the aborts. Will now merge this work.