Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop] Adding mixed-layer convective available potential energy (MLCAPE) to the verification #614

Merged
merged 7 commits into from
Feb 15, 2023
Merged

[develop] Adding mixed-layer convective available potential energy (MLCAPE) to the verification #614

merged 7 commits into from
Feb 15, 2023

Conversation

panll
Copy link
Collaborator

@panll panll commented Feb 13, 2023

DESCRIPTION OF CHANGES:

Adding MLCAPE to the verification configure files:
metplus/PointStat_conus_sfc.conf
metplus/PointStat_upper_air.conf

Type of change

  • New feature (non-breaking change which adds functionality)

TESTS CONDUCTED:

Tested on Hera.

  • [ x] hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

N/A

DOCUMENTATION:

ISSUE:

N/A

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • [x ] enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

@panll panll changed the title Adding mixing layer convective available energy (MLCAPE) to the verification Adding mixing layer convective available potential energy (MLCAPE) to the verification Feb 13, 2023
@panll panll changed the title Adding mixing layer convective available potential energy (MLCAPE) to the verification Adding mixing-layer convective available potential energy (MLCAPE) to the verification Feb 13, 2023
@MichaelLueken MichaelLueken changed the title Adding mixing-layer convective available potential energy (MLCAPE) to the verification [develop] Adding mixing-layer convective available potential energy (MLCAPE) to the verification Feb 13, 2023
@MichaelLueken MichaelLueken added the enhancement New feature or request label Feb 13, 2023
@JeffBeck-NOAA JeffBeck-NOAA changed the title [develop] Adding mixing-layer convective available potential energy (MLCAPE) to the verification [develop] Adding mixed-layer convective available potential energy (MLCAPE) to the verification Feb 13, 2023
JeffBeck-NOAA
JeffBeck-NOAA approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@JeffBeck-NOAA JeffBeck-NOAA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linlin-pan, thanks for getting MLCAPE incorporated and tested in the SRW App verification task!

@gsketefian
Copy link
Collaborator

@panll Is there any way to check whether the METplus output is reasonable?

@panll
Copy link
Collaborator Author

panll commented Feb 13, 2023

@panll Is there any way to check whether the METplus output is reasonable?

It can be verified by online sounding or other outputs (e.g., SHARPpy outputs) @gsketefian

@MichaelLueken
Copy link
Collaborator

@panll The two bug fixes that were merged into develop this morning include updates to the .cicd/Jenkinsfile that will be required before I can launch the Jenkins test for this PR. At your earliest convenience, please merge these two updates into your fork's develop branch. Thank you very much!

@panll
Copy link
Collaborator Author

panll commented Feb 15, 2023

@panll The two bug fixes that were merged into develop this morning include updates to the .cicd/Jenkinsfile that will be required before I can launch the Jenkins test for this PR. At your earliest convenience, please merge these two updates into your fork's develop branch. Thank you very much!

Updated. Please let me know if anything else is needed, thanks! @MichaelLueken

MichaelLueken
MichaelLueken approved these changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panll I was able to run the MET_verification and saw MLCAPE in the final STATS files. Approving this work.

@MichaelLueken MichaelLueken added ci-hera-intel-WE Kicks off automated workflow test on hera with intel run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests labels Feb 15, 2023
@venitahagerty venitahagerty removed the ci-hera-intel-WE Kicks off automated workflow test on hera with intel label Feb 15, 2023
@venitahagerty
Copy link
Collaborator

venitahagerty commented Feb 15, 2023 •
edited
Loading

Machine: hera
Compiler: intel
Job: WE
Repo location: /scratch1/BMC/zrtrr/rrfs_ci/autoci/pr/1239617486/20230215185019/ufs-srweather-app
Build was Successful
Rocoto jobs started
Long term tracking will be done on 10 experiments
If test failed, please make changes and add the following label back:
ci-hera-intel-WE
Experiment Succeeded on hera: community_ensemble_2mems_stoch
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: pregen_grid_orog_sfc_climo
Experiment Succeeded on hera: pregen_grid_orog_sfc_climo
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional_plot
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: community_ensemble_2mems_stoch
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional_plot
Experiment Succeeded on hera: MET_ensemble_verification
Experiment Succeeded on hera: MET_ensemble_verification
All experiments completed

@panll panll merged commit 80c5409 into ufs-community:develop Feb 15, 2023
@MichaelLueken MichaelLueken mentioned this pull request May 1, 2023
Merged
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsketefian gsketefian gsketefian approved these changes

@JeffBeck-NOAA JeffBeck-NOAA JeffBeck-NOAA approved these changes

@MichaelLueken MichaelLueken MichaelLueken approved these changes

@mkavulich mkavulich Awaiting requested review from mkavulich mkavulich is a code owner

@RatkoVasic-NOAA RatkoVasic-NOAA Awaiting requested review from RatkoVasic-NOAA RatkoVasic-NOAA is a code owner

@BenjaminBlake-NOAA BenjaminBlake-NOAA Awaiting requested review from BenjaminBlake-NOAA BenjaminBlake-NOAA is a code owner

@ywangwof ywangwof Awaiting requested review from ywangwof ywangwof is a code owner

@chan-hoo chan-hoo Awaiting requested review from chan-hoo chan-hoo is a code owner

@christinaholtNOAA christinaholtNOAA Awaiting requested review from christinaholtNOAA christinaholtNOAA is a code owner

@christopherwharrop-noaa christopherwharrop-noaa Awaiting requested review from christopherwharrop-noaa christopherwharrop-noaa is a code owner

@danielabdi-noaa danielabdi-noaa Awaiting requested review from danielabdi-noaa danielabdi-noaa is a code owner

@mark-a-potts mark-a-potts Awaiting requested review from mark-a-potts mark-a-potts is a code owner

@jkbk2004 jkbk2004 Awaiting requested review from jkbk2004 jkbk2004 is a code owner

@willmayfield willmayfield Awaiting requested review from willmayfield willmayfield is a code owner

@dmwright526 dmwright526 Awaiting requested review from dmwright526 dmwright526 is a code owner

@gspetro-NOAA gspetro-NOAA Awaiting requested review from gspetro-NOAA gspetro-NOAA is a code owner

@natalie-perlin natalie-perlin Awaiting requested review from natalie-perlin natalie-perlin is a code owner

@EdwardSnyder-NOAA EdwardSnyder-NOAA Awaiting requested review from EdwardSnyder-NOAA EdwardSnyder-NOAA is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@panll @gsketefian @MichaelLueken @venitahagerty @JeffBeck-NOAA @linlin-pan