-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Add new ccpp physics suite 'FV3_GFS_v17_p8' #574
[develop] Add new ccpp physics suite 'FV3_GFS_v17_p8' #574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
b011cfd
to
25418e8
Compare
…IC no longer has an account to run on Hera - no longer allowed to use nems account).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chan-hoo Thank you very much for making adding the FV3_GFS_v17_p8
CCPP physics suite to the SRW App! I just pushed a minor update, turning off the Hera Jenkins pipeline since EPIC can no longer run on Hera using the nems account and we haven't been given a new allocation as of this time. I was able to test your newly added grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8
test on Jet without issue. Approving these changes now.
@chan-hoo Before I move forward and merge this work, would you be able to merge the latest develop updates from today into your feature/ccpp_gfs_v17p8 branch? Two of these modifications are to correct the failures in the unit tests and I'd like to make sure that, moving forward, no further failures are introduced. Thanks! |
…her-app into feature/ccpp_gfs_v17p8
I found an issue on the conus 3km domain. please do not merge this PR yet. |
The issue on the 3km domain has been resolved. |
DESCRIPTION OF CHANGES:
FV3_GFS_v17_p8
to the UFS SRW App.Type of change
TESTS CONDUCTED:
WE2E tests:
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8 (new)
hera.intel
orion.intel
cheyenne.intel
cheyenne.gnu
gaea.intel
jet.intel
wcoss2.intel
NOAA Cloud (indicate which platform)
Jenkins
fundamental test suite
comprehensive tests (specify which if a subset was used)
ISSUE:
Fixes issue mentioned in #573
CHECKLIST
CONTRIBUTORS:
@yangfanglin @ChunxiZhang-NOAA