Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Add new ccpp physics suite 'FV3_GFS_v17_p8' #574

Merged

Conversation

chan-hoo
Copy link
Collaborator

@chan-hoo chan-hoo commented Feb 2, 2023

DESCRIPTION OF CHANGES:

  • Add the CCPP physics suite FV3_GFS_v17_p8 to the UFS SRW App.
  • Add a new WE2E test for the new suite.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • WE2E tests:
    grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
    grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8 (new)

  • hera.intel

  • orion.intel

  • cheyenne.intel

  • cheyenne.gnu

  • gaea.intel

  • jet.intel

  • wcoss2.intel

  • NOAA Cloud (indicate which platform)

  • Jenkins

  • fundamental test suite

  • comprehensive tests (specify which if a subset was used)

ISSUE:

Fixes issue mentioned in #573

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

CONTRIBUTORS:

@yangfanglin @ChunxiZhang-NOAA

Copy link
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@MichaelLueken MichaelLueken linked an issue Feb 2, 2023 that may be closed by this pull request
@mkavulich mkavulich force-pushed the develop branch 2 times, most recently from b011cfd to 25418e8 Compare February 2, 2023 20:13
…IC no longer has an account to run on Hera - no longer allowed to use nems account).
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chan-hoo Thank you very much for making adding the FV3_GFS_v17_p8 CCPP physics suite to the SRW App! I just pushed a minor update, turning off the Hera Jenkins pipeline since EPIC can no longer run on Hera using the nems account and we haven't been given a new allocation as of this time. I was able to test your newly added grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8 test on Jet without issue. Approving these changes now.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Feb 7, 2023
@MichaelLueken
Copy link
Collaborator

@chan-hoo Before I move forward and merge this work, would you be able to merge the latest develop updates from today into your feature/ccpp_gfs_v17p8 branch? Two of these modifications are to correct the failures in the unit tests and I'd like to make sure that, moving forward, no further failures are introduced. Thanks!

@chan-hoo chan-hoo added the DO_NOT_MERGE Ensure that a PR isn't merged label Feb 8, 2023
@chan-hoo
Copy link
Collaborator Author

chan-hoo commented Feb 8, 2023

I found an issue on the conus 3km domain. please do not merge this PR yet.

@chan-hoo chan-hoo removed the DO_NOT_MERGE Ensure that a PR isn't merged label Feb 8, 2023
@chan-hoo
Copy link
Collaborator Author

chan-hoo commented Feb 8, 2023

The issue on the 3km domain has been resolved.

@MichaelLueken MichaelLueken merged commit 4997e4f into ufs-community:develop Feb 8, 2023
@chan-hoo chan-hoo deleted the feature/ccpp_gfs_v17p8 branch February 27, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CCPP physics suite 'FV3_GFS_v17_p8' does not work in UFS SRW App.
4 participants