Update manage_externals for Python 3+ bug fix, support for 3.7 and 3.8 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBeck-NOAA
requested review from
gsketefian,
JulieSchramm and
mkavulich
as code owners
JeffBeck-NOAA
changed the title
|
I still need to run ncar_pylib /glade/p/ral/jntp/UFS_CAM/ncar_pylib_20200427 on Cheyenne to generate the workflow. Is this expected behavior? |
|
@JulieSchramm If that Cheyenne command was required to load a version of Python for the workflow, then yes, that's still required. |
|
I can run manage_externals without the ncar_pylib command and it works
fine, then I need the ncar_pylib command to run ./generate_FV3SAR_wflow.sh,
as we were doing before this PR.
…On Thu, Sep 10, 2020 at 3:08 PM JeffBeck-NOAA ***@***.***> wrote:
@JulieSchramm <https://github.com/JulieSchramm> If that Cheyenne command
is to load a version of Python for both manage_externals and the workflow,
then yes, that's still required.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3WNU6URKHNXJBANQZA3R3SFE55XANCNFSM4RFVJBCQ>
.
|
|
@JulieSchramm That sounds like normal behavior. Did you previously need the "ncar_pylib" command for manage_externals? The Python version (or some related library) required for the generate script may not be loaded by default on Cheyenne, and may still require you to run the ncar_pylib command. |
|
I didn't need the ncar_pylib command previously to run manage_externals.
…On Thu, Sep 10, 2020 at 3:26 PM JeffBeck-NOAA ***@***.***> wrote:
@JulieSchramm <https://github.com/JulieSchramm> That sounds like normal
behavior. Did you previously need the "ncar_pylib" command for
manage_externals? The Python version required for the generate script may
not be the default on Cheyenne, and may still require you to run the
ncar_pylib command.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3WNU4GUI3GWPLI6VIX3OLSFFAANANCNFSM4RFVJBCQ>
.
|
|
@JulieSchramm OK, then everything is working as expected. Thanks for testing! |
christinaholtNOAA
pushed a commit
to christinaholtNOAA/ufs-srweather-app
that referenced
this pull request
Apr 27, 2021
* Add GSI and rrfs_utl and their compile environments. * Add compile enviroment, Cmakefile, and scripts for data assimilation compnents. * Add compile enviroment, Cmakefile, and scripts for data assimilation compnents. * Update the DA compile method. * Update Hash number for chgres_cube to fix the problem of missing initial hydrometeors.
natalie-perlin
pushed a commit
to natalie-perlin/ufs-srweather-app
that referenced
this pull request
Jun 2, 2024
…led model (ufs-community#254) * Implements a bugfix for the mapping of ifrac for both nems_orig and nems_frac in CMEPS: issue (ufs-community#17)[NOAA-EMC/CMEPS#17] * Adds field-packing for performance improvements in CMEPS: issue (ufs-community#23)[NOAA-EMC/CMEPS#23] * Uses module file fv3_debug when DEBUG=Y is specified and fv3_debug is available * Shortens the nems.configure file name used with the coupled model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Updates manage_externals to the most recent release which includes a critical Python 3+ bug fix and supports 3.7 and 3.8. This new version avoids the previous incompatibility between manage_externals and the YAML namelist generation/Jinja templating for XML and diag_table files. Users will no longer have to load different versions of Python in-between manage_externals and running the workflow.
TESTS CONDUCTED:
Tested successfully on Hera. All repos are cloned correctly. @JulieSchramm tested on Cheyenne.