-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop]: Updated ConfigWorkflow.rst to reflect changes to config_defaults.yaml (PI12) #1095
Conversation
Co-authored-by: Gillian Petro <[email protected]>
Co-authored-by: Gillian Petro <[email protected]>
Co-authored-by: Gillian Petro <[email protected]>
Co-authored-by: Gillian Petro <[email protected]>
Co-authored-by: Gillian Petro <[email protected]>
Co-authored-by: Gillian Petro <[email protected]>
Co-authored-by: Gillian Petro <[email protected]>
Co-authored-by: Gillian Petro <[email protected]>
Co-authored-by: Gillian Petro <[email protected]>
Co-authored-by: Gillian Petro <[email protected]>
@jdkublnick Could you change the line that says:
to:
I can't comment directly on the code since it hasn't been altered in this PR. |
Co-authored-by: Gillian Petro <[email protected]>
Co-authored-by: Gillian Petro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! @jdkublnick addressed all my feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, these changes look good!
I did note a minor difference with PTMP
(rather than PTMP_default
) and the default being '{{ workflow.EXPT_BASEDIR }}/../nco_dirs'
.
Co-authored-by: Michael Lueken <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jdkublnick!
Approving now.
@jdkublnick I also just realized that maybe the default value for |
Updated |
DESCRIPTION OF CHANGES:
Type of change
TESTS CONDUCTED:
None required for documentation. The docs build successfully on my fork and can be viewed at: https://ufs-srweather-app-joshua-kublnick.readthedocs.io/en/text-us-283/UsersGuide/index.html
DEPENDENCIES:
N/A
DOCUMENTATION:
All documentation
ISSUE:
Issue #1094
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):
@gspetro-NOAA