Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop]: Updated ConfigWorkflow.rst to reflect changes to config_defaults.yaml (PI12) #1095

Merged
merged 18 commits into from
Jun 21, 2024

Conversation

jdkublnick
Copy link
Contributor

DESCRIPTION OF CHANGES:

  • Updated ConfigWorkflow.rst to reflect recent changes to config_defaults.yaml in order to keep documentation up to date.

Type of change

  • [X ] This change requires a documentation update

TESTS CONDUCTED:

None required for documentation. The docs build successfully on my fork and can be viewed at: https://ufs-srweather-app-joshua-kublnick.readthedocs.io/en/text-us-283/UsersGuide/index.html

DEPENDENCIES:

N/A

DOCUMENTATION:

All documentation

ISSUE:

Issue #1094

CHECKLIST

  • [X ] My code follows the style guidelines in the Contributor's Guide
  • [X ] I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • [X ] My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • [X ] My changes generate no new warnings
  • New and existing tests pass with my changes
  • [ X] Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • [X ] documentation

CONTRIBUTORS (optional):

@gspetro-NOAA

@gspetro-NOAA
Copy link
Collaborator

@jdkublnick Could you change the line that says:

``KMP_AFFINITY_BIAS_CORRECTION_O3``: "scatter"

to:

``KMP_AFFINITY_BIAS_CORRECTION_O3``: (Default: "scatter")

I can't comment directly on the code since it hasn't been altered in this PR.

@jdkublnick jdkublnick marked this pull request as ready for review June 20, 2024 14:40
Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @jdkublnick addressed all my feedback.

Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdkublnick -

Overall, these changes look good!

I did note a minor difference with PTMP (rather than PTMP_default) and the default being '{{ workflow.EXPT_BASEDIR }}/../nco_dirs'.

doc/UsersGuide/CustomizingTheWorkflow/ConfigWorkflow.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jdkublnick!

Approving now.

@gspetro-NOAA
Copy link
Collaborator

@jdkublnick I also just realized that maybe the default value for CCPP_PHYS_DIR should be updated to '{{ [user.UFS_WTHR_MDL_DIR, "FV3", "ccpp", "physics", "physics", "SFC_Models", "Land", "Noahmp"] |path_join }}'?

@jdkublnick
Copy link
Contributor Author

@jdkublnick I also just realized that maybe the default value for CCPP_PHYS_DIR should be updated to '{{ [user.UFS_WTHR_MDL_DIR, "FV3", "ccpp", "physics", "physics", "SFC_Models", "Land", "Noahmp"] |path_join }}'?

Updated

@MichaelLueken MichaelLueken merged commit fe8fc68 into ufs-community:develop Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigWorkflow.rst needs to be updated to reflect changes to config_defaults.yaml (PI12)
3 participants