[develop] Upgrade SRW to spack-stack 1.6.0 from 1.5.1 #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RatkoVasic-NOAA
requested review from
mkavulich,
gsketefian,
JeffBeck-NOAA,
BenjaminBlake-NOAA,
ywangwof,
chan-hoo,
panll,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
mark-a-potts,
jkbk2004,
willmayfield,
dmwright526,
gspetro-NOAA,
natalie-perlin,
EdwardSnyder-NOAA and
MichaelLueken
as code owners
|
Fundamental tests. GAEA: ORION: HERCULES: DERECHO: |
|
AQM test on Hera: Approving. |
chan-hoo
approved these changes
Jun 11, 2024
MichaelLueken
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
These changes look good to me!
The fundamental tests were run on Hera GNU (given the update from GNU 9.2.0 to 13.3.0) and all tests successfully passed:
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2 COMPLETE 12.93
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20240 COMPLETE 9.43
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot COMPLETE 20.35
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024061 COMPLETE 47.26
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20240611133 COMPLETE 32.30
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024061113312 COMPLETE 37.38
----------------------------------------------------------------------------------------------------
Total COMPLETE 159.65
The AQM WE2E test was also run and passed successfully:
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
aqm_grid_AQM_NA13km_suite_GFS_v16_20240611144245 COMPLETE 5352.87
----------------------------------------------------------------------------------------------------
Total COMPLETE 5352.87
Approving now.
|
Given that Jet /lfs4 is still down, Derecho being down for maintenance today, and Orion undergoing the OS migration tomorrow and Thursday, I will hold off on automated testing until spack-stack 1.6.0 is ready on Orion Rocky 9. By then, Jet should hopefully be back, as well as Derecho. |
OK, their guess is that they will upgrade Orion by 6/12-13, which means we can start building libraries 6/14. Since there are plenty of versions and different environments, I will start with spack-stack 1.6.0 |
|
With the return of Jet /lfs4 yesterday afternoon, the fundamental tests were run and all tests successfully passed: |
|
Successfully built and ran the fundamental test suite on AWS, Azure, and GCP using spack-stack v1.6.0. Had some issues running the tests on Azure. Jobs would just sit in the queue for hours without running or they would fail with this mpi error message: GCP: AWS: Azure: |
|
@MichaelLueken with last addition of Orion modulefiles (although cannot be tested for some time), I think this PR is ready for final testing. |
|
Thanks, @RatkoVasic-NOAA! I'll launch Jenkins tests for this PR now. |
MichaelLueken
added
the
run_we2e_coverage_tests
MichaelLueken
changed the title
|
There are issues with Jenkins on Orion following the OS migration and software stack update. Jenkins is attempting to use Manual runs of the Orion coverage tests have successfully passed: and the SRW Metrics test also successfully passed: Will now move forward with merging this PR. |
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
As ufs-weather-model was upgraded to spack-stack 1.6.0, we are upgrading SRW as well.
Type of change
TESTS CONDUCTED:
ISSUE:
Issue #1092
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):
@natalie-perlin