-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Replace existing UW CLI with UW API calls to template #1078
[develop] Replace existing UW CLI with UW API calls to template #1078
Conversation
ush/create_aqm_rc_file.py
Outdated
render( | ||
input_file = Path(AQM_RC_TMPL_FP), | ||
output_file = Path(aqm_rc_fp), | ||
values_src = settings, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These same simplifications are repeated throughout these 5 files. Further info on template.render()
can be found on the uwtools Read the Docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very happy to see removal of the ugly temp files and subprocesses! Looks good to me, assuming all tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me! I have also run fundamental tests on Derecho:
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2 COMPLETE 19.75
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20240 COMPLETE 17.30
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot COMPLETE 33.08
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024042 COMPLETE 36.42
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20240425093 COMPLETE 33.99
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024042509365 COMPLETE 48.73
----------------------------------------------------------------------------------------------------
Total COMPLETE 189.27
and Hercules:
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2 COMPLETE 11.11
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20240 COMPLETE 8.64
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot COMPLETE 15.98
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024042 COMPLETE 238.56
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20240425121 COMPLETE 77.96
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024042512175 COMPLETE 26.14
----------------------------------------------------------------------------------------------------
Total COMPLETE 378.39
and they all successfully passed.
Approving this PR now.
The Jenkins tests have successfully completed on Derecho, Gaea, Hera GNU, Hera Intel, and Hercules. The Jet tests were manually run and all successfully passed:
Due to the continued degraded state of Orion and the additional maintenance today following the cooling issue that was encountered Wednesday night - Thursday morning, the Orion tests will not be run. |
DESCRIPTION OF CHANGES:
This PR continues the integration of the uwtools package by replacing current use of the UW CLI with UW API calls in Python scripts. These changes are limited to the UW template tool.
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
n/a
DOCUMENTATION:
None. UW Documentation is up-to-date.
CHECKLIST