Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to spack-stack-1.7.0 #1070

Draft
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

RatkoVasic-NOAA
Copy link
Collaborator

DESCRIPTION OF CHANGES:

We have new version of spack-stack available. This pull request make sure we load correct modules for SRW.

Type of change

  • New feature (non-breaking change which adds functionality)

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • hercules.intel
  • derecho.intel
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests

DEPENDENCIES:

N/A

DOCUMENTATION:

N/A

ISSUE:

Solves issue #1069

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

@MichaelLueken MichaelLueken linked an issue Apr 10, 2024 that may be closed by this pull request

load(pathJoin("stack-intel", os.getenv("stack_intel_ver") or "2021.10.0"))
load(pathJoin("stack-cray-mpich", os.getenv("stack_cray_mpich_ver") or "8.1.25"))
load(pathJoin("cmake", os.getenv("cmake_ver") or "3.26.3"))
load(pathJoin("cmake", os.getenv("cmake_ver") or "3.23.1"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this CMake version downgrade?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkavulich, just used cmake build by spack-stack vs. using one built by admins. It was to be consistent with other machines which use spack-stack built cmake (3.23.1).
For Derecho, we can go with 3.26.3 if needed.

Copy link
Collaborator

@mkavulich mkavulich Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation, I didn't realize we were previously using the platform build instead of through spack. It's not necessary, I was just curious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to spack-stack 1.7.0
3 participants