Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Update weather model hash and correct behavior in Functional WorkflowTaskTests Jenkins stage #1068

Merged
merged 11 commits into from
Apr 15, 2024

Conversation

MichaelLueken
Copy link
Collaborator

DESCRIPTION OF CHANGES:

  • The ufs-weather-model hash has been updated to 1411b90 (April 1, 2024).
  • Updated build_hera_gnu.lua file to allow it to work with updates to the ufs-weather-model.
  • Updated behavior of the Functional WorkflowTaskTests Jenkins stage to allow the test to properly finish, rather than waiting in queue for all jobs associated with the EPIC role account to finish first (modification to .cicd/scripts/wrapper_srw_ftest.sh).
  • Corrected the hang encountered while running the Functional WorkflowTaskTests stage on Gaea.
  • Applied Mike Kavulich's modification to ush/bash_utils/create_symlink_to_file.sh and converted calls to the create_symlink_to_file function from using named arguments to positional arguments (Issue create_symlink_to_file.sh is unreasonably slow #1066).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • hercules.intel
  • derecho.intel
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)
    Fundamental tests were ran on all machines and comprehensive tests were ran on Hera, Hercules, and Orion.

ISSUE:

Fixes #1066

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes

CONTRIBUTORS (optional):

@mkavulich - For opening issue #1066 and providing the diff to convert create_symlink_to_file from using named arguments to positional arguments.

… the Functional WorkflowTaskTests stage on Gaea
…g jobs won't keep the pipeline from progressing past the functional workflowtasktests stage
 * modulefiles/build_hera_gnu.lua - Corrected the ufs-weather-model build on Hera GNU
 * Issue ufs-community#1066 -
   * ush/bash_utils/create_symlink_to_file.sh - Applied Mike Kavulich's changes to remove ln_vrfy and use positional arguments instead of named arguments
   * scripts/exregional_make_orog.sh - Changed to use positional arguents instead of named arguments while calling create_symlink_to_file function
   * scripts/exregiona_run_fcst.sh - Same
   * scripts/exregional_run_post.sh - Same
@chan-hoo
Copy link
Collaborator

chan-hoo commented Apr 9, 2024

Experiment grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot_20240409094155 is COMPLETE
Took 0:21:53.052508; will no longer monitor.
All 1 experiments finished
Calculating core-hour usage and printing final summary
----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              30.80
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE              30.80

It passed one we2e test on Derecho. Approving.

@MichaelLueken
Copy link
Collaborator Author

Thanks for the review and approval, @chan-hoo!

@RatkoVasic-NOAA
Copy link
Collaborator

I tested fundamental tests on Hera, GNU.

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE              12.83
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20240  COMPLETE               9.98
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              20.47
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024040  COMPLETE              47.58
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20240409163  COMPLETE              32.67
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024040916382  COMPLETE              38.38
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             161.91

Looks good, approving.

@MichaelLueken
Copy link
Collaborator Author

Thanks, @RatkoVasic-NOAA!

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Apr 11, 2024
@MichaelLueken MichaelLueken merged commit c7e093d into ufs-community:develop Apr 15, 2024
2 checks passed
@MichaelLueken MichaelLueken deleted the feature/hash_update branch April 15, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_symlink_to_file.sh is unreasonably slow
3 participants